[ 
https://issues.apache.org/jira/browse/GEODE-10049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Owen Nichols closed GEODE-10049.
--------------------------------

> Redis tests should include the entire error response message rather than just 
> the error type
> --------------------------------------------------------------------------------------------
>
>                 Key: GEODE-10049
>                 URL: https://issues.apache.org/jira/browse/GEODE-10049
>             Project: Geode
>          Issue Type: Test
>          Components: redis
>    Affects Versions: 1.15.0
>            Reporter: Donal Evans
>            Assignee: Donal Evans
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.15.0
>
>
> Currently many tests look for substrings of error messages, rather than the 
> error message as a whole. This has in the past led to cases where the Geode 
> for Redis Module's error messages have not precisely matched those of native 
> Redis.
> For example, if the test is:
> {code:java}
> assertThatThrownBy(
>         () -> jedis.hsetnx(string_key, field, "something else"))
>             .isInstanceOf(JedisDataException.class)
>             .hasMessageContaining("WRONGTYPE");{code}
> instead we should probably look for the full error message that native Redis 
> puts out:
> {code:java}
> .hasMessage("WRONGTYPE Operation against a key holding the wrong kind of 
> value"){code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to