Jinwoo Hwang created GEODE-10551:
------------------------------------
Summary: Update GitHub Actions workflows to trigger on support/2.0
branch
Key: GEODE-10551
URL: https://issues.apache.org/jira/browse/GEODE-10551
Project: Geode
Issue Type: Improvement
Reporter: Jinwoo Hwang
h2. Summary
Update GitHub Actions workflow files on the support/2.0 branch to enable
automated CI/CD checks for pull requests targeting this branch, similar to what
was implemented for support/1.15 in GEODE-10550.
h2. Description
The support/2.0 branch currently has GitHub Actions workflow files
({{{}.github/workflows/codeql.yml{}}} and
{{{}.github/workflows/gradle.yml{}}}), but they are configured to run on the
"develop" branch instead of "support/2.0". This means automated checks are not
triggered for pull requests targeting the support/2.0 branch.
h3. Current State
* Workflow files exist on support/2.0 branch but are configured incorrectly
* Both {{codeql.yml}} and {{gradle.yml}} have {{branches: [ "develop" ]}}
configuration
* No automated CI/CD runs for PRs targeting support/2.0
h3. Expected Behavior
Similar to the support/1.15 branch implementation (commit 79a74d001f), the
workflow files should:
* Trigger on push events to support/2.0 branch
* Trigger on pull requests targeting support/2.0 branch
* Run scheduled weekly security scans (CodeQL only)
* Use Java 17 (not Java 8 like support/1.15)
h2. Technical Details
h3. Files to Update
# {{.github/workflows/codeql.yml}}
** Change {{branches: [ develop ]}} to {{branches: [ support/2.0 ]}} (appears
twice - in push and pull_request sections)
# {{.github/workflows/gradle.yml}}
** Change {{branches: [ "develop" ]}} to {{branches: [ "support/2.0" ]}}
(appears twice - in push and pull_request sections)
h3. Key Differences from support/1.15
* {*}Java Version{*}: Support/2.0 uses Java 17 (not Java 8 like support/1.15)
* {*}Build Configuration{*}: Support/2.0 may have different Gradle properties
and build requirements
* The workflow files should maintain Java 17 configuration (already present in
the files)
h2. Implementation Steps
# Checkout support/2.0 branch
# Update {{{}.github/workflows/codeql.yml{}}}:
** Line ~33: Change {{branches: [ develop ]}} to {{branches: [ support/2.0 ]}}
** Line ~35: Change {{branches: [ develop ]}} to {{branches: [ support/2.0 ]}}
# Update {{{}.github/workflows/gradle.yml{}}}:
** Line ~23: Change {{branches: [ "develop" ]}} to {{branches: [ "support/2.0"
]}}
** Line ~25: Change {{branches: [ "develop" ]}} to {{branches: [ "support/2.0"
]}}
# Test the workflow by creating a test PR targeting support/2.0
# Verify all jobs execute successfully
h2. Testing
* Create a test PR targeting support/2.0 branch
* Verify the following workflows trigger:
** Build job
** API Check
** Unit tests
** Integration tests
** Acceptance tests
** Distributed tests (WAN, CQ, Lucene, Management, Assembly)
** CodeQL security scanning
h2. Benefits
* Ensures dependency updates and security fixes submitted to support/2.0 are
validated before merge
* Provides automated feedback on PR quality and compatibility
* Prevents breaking changes from being merged
* Maintains consistency with other support branches
h2. References
* GEODE-10550: Enable GitHub Actions workflows for support/1.15 branch (commit
79a74d001f)
* Support/2.0 branch already uses Java 17 configuration
* Current support/2.0 HEAD: b1247eb32f
h2. Acceptance Criteria
* Workflow files updated to reference support/2.0 branch instead of develop
* Push to support/2.0 triggers all workflow jobs
* Pull requests targeting support/2.0 trigger all workflow jobs
* CodeQL scheduled scans configured for weekly execution
* All existing Java 17 configuration preserved
* Test PR validates workflows execute successfully
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
