[
https://issues.apache.org/jira/browse/GEODE-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18056862#comment-18056862
] ASF GitHub Bot commented on GEODE-2484: --------------------------------------- codecov-commenter commented on PR #601: URL: https://github.com/apache/geode-native/pull/601#issuecomment-3858916992 ## [Codecov](https://app.codecov.io/gh/apache/geode-native/pull/601?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `43.29897%` with `55 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 73.28%. Comparing base ([`9bc3e0a`](https://app.codecov.io/gh/apache/geode-native/commit/9bc3e0a930fab6d7a58c684bffcb47c9325ba575?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`37d14b7`](https://app.codecov.io/gh/apache/geode-native/commit/37d14b7535894cccc5c0bf122054a515d1b5213a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 346 commits behind head on develop. | [Files with missing lines](https://app.codecov.io/gh/apache/geode-native/pull/601?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [cppcache/src/TssConnectionWrapper.cpp](https://app.codecov.io/gh/apache/geode-native/pull/601?src=pr&el=tree&filepath=cppcache%2Fsrc%2FTssConnectionWrapper.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y3BwY2FjaGUvc3JjL1Rzc0Nvbm5lY3Rpb25XcmFwcGVyLmNwcA==) | 13.72% | [44 Missing :warning: ](https://app.codecov.io/gh/apache/geode-native/pull/601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [cppcache/src/ThinClientStickyManager.cpp](https://app.codecov.io/gh/apache/geode-native/pull/601?src=pr&el=tree&filepath=cppcache%2Fsrc%2FThinClientStickyManager.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRTdGlja3lNYW5hZ2VyLmNwcA==) | 78.57% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/geode-native/pull/601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [cppcache/src/ThinClientPoolStickyDM.cpp](https://app.codecov.io/gh/apache/geode-native/pull/601?src=pr&el=tree&filepath=cppcache%2Fsrc%2FThinClientPoolStickyDM.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRQb29sU3RpY2t5RE0uY3Bw) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/geode-native/pull/601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [cppcache/src/TssConnectionWrapper.hpp](https://app.codecov.io/gh/apache/geode-native/pull/601?src=pr&el=tree&filepath=cppcache%2Fsrc%2FTssConnectionWrapper.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y3BwY2FjaGUvc3JjL1Rzc0Nvbm5lY3Rpb25XcmFwcGVyLmhwcA==) | 75.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/geode-native/pull/601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [cppcache/src/TcrEndpoint.hpp](https://app.codecov.io/gh/apache/geode-native/pull/601?src=pr&el=tree&filepath=cppcache%2Fsrc%2FTcrEndpoint.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y3BwY2FjaGUvc3JjL1RjckVuZHBvaW50LmhwcA==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/geode-native/pull/601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## develop #601 +/- ## =========================================== - Coverage 73.56% 73.28% -0.28% =========================================== Files 638 638 Lines 50845 50822 -23 =========================================== - Hits 37402 37245 -157 - Misses 13443 13577 +134 ``` </details> [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/geode-native/pull/601?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. </details> > Remove ACE from native client dependencies > ------------------------------------------ > > Key: GEODE-2484 > URL: https://issues.apache.org/jira/browse/GEODE-2484 > Project: Geode > Issue Type: Task > Components: native client > Reporter: David Kimura > Priority: Major > Labels: pull-request-available > Fix For: 1.9.0 > > Time Spent: 11h 20m > Remaining Estimate: 0h > > Remove ACE from native client dependencies. > Replace ACE usage with C++11 and/or Boost 1.63+ -- This message was sent by Atlassian Jira (v8.20.10#820010)
