[
https://issues.apache.org/jira/browse/GEODE-9078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18102310#comment-18102310
]
ASF GitHub Bot commented on GEODE-9078:
---------------------------------------
m3i54 commented on code in PR #776:
URL: https://github.com/apache/geode-native/pull/776#discussion_r623778380
##########
cppcache/src/AdminRegion.hpp:
##########
@@ -48,7 +48,7 @@ class AdminRegion : public
std::enable_shared_from_this<AdminRegion> {
ThinClientBaseDM* m_distMngr;
std::string m_fullPath;
TcrConnectionManager* m_connectionMgr;
- ACE_RW_Thread_Mutex m_rwLock;
+ boost::shared_mutex mutex_;
Review Comment:
I am trying to keep changes as minimal as possible. I have to confess every
time I see something wrong, like this my OCD triggers and I am tempted to
change it, but as I said I am trying to hold back hehe. However if you consider
this is not a big change, I will update all the member variable names to match
the current standard.
> Remove ACE mutexes
> ------------------
>
> Key: GEODE-9078
> URL: https://issues.apache.org/jira/browse/GEODE-9078
> Project: Geode
> Issue Type: Task
> Components: native client
> Reporter: Mario Salazar de Torres
> Assignee: Mario Salazar de Torres
> Priority: Major
> Labels: obliterate-ace, pull-request-available
>
> *AS AN* geode-native contributor
> *I WANT TO* remove all occurrences of ACE mutexes
> *SO THAT* we can get rid of ACE for good
--
This message was sent by Atlassian Jira
(v8.20.10#820010)