[
https://issues.apache.org/jira/browse/GEODE-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14596505#comment-14596505
]
William Markito Oliveira edited comment on GEODE-20 at 6/22/15 7:31 PM:
------------------------------------------------------------------------
Thanks Wes, a couple of comments here:
You already had a pull request open for this change and I don't think this one
looks different, can you confirm so I'll go ahead and close the #2.
- https://github.com/apache/incubator-geode/pull/9
- https://github.com/apache/incubator-geode/pull/2
There is a failing due to the need for GEMFIRE enviroment variable:
{code}
Class com.gemstone.gemfire.management.internal.AgentUtilJUnitTest
java.lang.AssertionError: The GEMFIRE environment variable must be set!
{code}
I'm going to work on this... Looks like this test would actually be an
IntegrationTest and not really a UnitTest so I'm moving it gemfire-assembly, so
gemfire-web-api would be already built and in place in order to test.
was (Author: markito):
Thanks Wes, a couple of comments here:
You already had a pull request open for this change and I don't think this one
looks different, can you confirm so I'll go ahead and close the #2.
- https://github.com/apache/incubator-geode/pull/9
- https://github.com/apache/incubator-geode/pull/2
There is a failing due to the need for GEMFIRE enviroment variable:
{code}
Class com.gemstone.gemfire.management.internal.AgentUtilJUnitTest
java.lang.AssertionError: The GEMFIRE environment variable must be set!
{code}
I'm going to work on this... Looks like this test would actually be an
IntegrationTest and really a UnitTest so I'm moving it gemfire-assembly, so
gemfire-web-api would be already built and in place in order to test.
> Allow REST web API to be launched. Eliminate duplicate code
> -----------------------------------------------------------
>
> Key: GEODE-20
> URL: https://issues.apache.org/jira/browse/GEODE-20
> Project: Geode
> Issue Type: Bug
> Components: management & tools
> Affects Versions: 1.0.0-incubating
> Reporter: Wes Williams
> Assignee: Wes Williams
> Fix For: 1.0.0-incubating
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> GitHub user wwilliams-pivotal opened a pull request:
> https://github.com/apache/incubator-geode/pull/2
> Allow REST web API to be launched. Eliminate duplicate code
> - Refactored duplicate code into a common class
> - Changed the return for the web rest dev api to return gemfire-web-api
> instead of gemfire-web
> - Applied standard formatting conventions against the existing classes
> per code policy
> - Added unit test to check for existence of gemfire-web-api jar
> You can merge this pull request into a Git repository by running:
> $ git pull https://github.com/wwilliams-pivotal/incubator-geode master
> Alternatively you can review and apply these changes as the patch at:
> https://github.com/apache/incubator-geode/pull/2.patch
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
> This closes #2
> To make the review simpler, the only two material changes are below. All of
> the rest is/ (should be) duplicate code refactoring or source code formatting
> according to the conventions that Anthony sent out earlier.
> ManagementAgent
> -
> - //Find developer REST WAR file
> - final String gemfireAPIWar = getGemFireAPIWarLocation(gemfireHome);
> +
> + // Find developer REST WAR file
> + final String gemfireAPIWar = agentUtil.getGemFireWebApiWarLocation();
> ​RestAgent
> -
> - final String gemfireAPIWar = getGemFireAPIWarLocation(gemfireHome);
> - if(gemfireAPIWar == null){
> - logger.info("Unable to find GemFire Developer REST API WAR file; the
> Developer REST API for GemFire will not be exported and accessible.");
> + final String gemfireAPIWar = agentUtil.getGemFireWebApiWarLocation();
> + if (gemfireAPIWar == null) {
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
