[
https://issues.apache.org/jira/browse/GEODE-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654882#comment-14654882
]
ASF subversion and git services commented on GEODE-155:
-------------------------------------------------------
Commit 8e4c70429f30d39c65330d9397325928780e9c56 in incubator-geode's branch
refs/heads/develop from [~ashetkar]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=8e4c704 ]
GEODE-155:
- Fixes intermittent failure in RegionWithHDFS*DUnitTest about incorrect number
of hoplog files getting created.
- Caused due to an earlier test not cleaning up static variables in
ParallelGatewaySenderQueue.
- These are indeed cleaned up during GemFireCacheImpl.close() if there are any
GatewaySenders running in the system.
- But if a region with gateway-senders associated with it, is destroyed first
before a cache.close(), then the gateway senders are only stopped,
and removed from allGatewaySenders list. But the static variables are not
cleaned up.
- Later, during GemFireCacheImpl.close(), as the allGatewaySenders list is
empty, it skips cleaning the static variables.
- As a fix, invoking a static clean-up method of ParallelGatewaySenderQueue
explicitly during cache.close().
- Retained the non-static ParallelGatewaySenderQueue.cleanUp(), if required in
future development for performing instance-specific clean-up.
- Minor formatting changes in the unit tests.
> RegionWithHDFS*BasicDUnitTest.testWOTimeForRollOverParam failed due to
> incorrect number of files created.
> ---------------------------------------------------------------------------------------------------------
>
> Key: GEODE-155
> URL: https://issues.apache.org/jira/browse/GEODE-155
> Project: Geode
> Issue Type: Bug
> Components: hdfs
> Affects Versions: 1.0.0-incubating
> Reporter: Amogh Shetkar
> Assignee: Amogh Shetkar
>
> The same test case in two distributed tests failed with the same error in
> Jenkins build #165.
> {code}
> com.gemstone.gemfire.cache.hdfs.internal.RegionWithHDFSOffHeapBasicDUnitTest
> > testWOTimeForRollOverParam FAILED
> junit.framework.AssertionFailedError: there should be exactly two files,
> but there are 1
> com.gemstone.gemfire.cache.hdfs.internal.RegionWithHDFSBasicDUnitTest >
> testWOTimeForRollOverParam FAILED
> junit.framework.AssertionFailedError: there should be exactly two files,
> but there are 1
> at junit.framework.Assert.fail(Assert.java:57)
> at junit.framework.Assert.assertTrue(Assert.java:22)
> at junit.framework.TestCase.assertTrue(TestCase.java:192)
> at
> com.gemstone.gemfire.cache.hdfs.internal.RegionWithHDFSBasicDUnitTest.verifyTwoHDFSFiles(RegionWithHDFSBasicDUnitTest.java:1075)
> at
> com.gemstone.gemfire.cache.hdfs.internal.RegionWithHDFSBasicDUnitTest.testWOTimeForRollOverParam(RegionWithHDFSBasicDUnitTest.java:1023)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
