[
https://issues.apache.org/jira/browse/GEODE-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14745890#comment-14745890
]
William Markito Oliveira commented on GEODE-60:
-----------------------------------------------
Hi [~jaoki] I finally got some time to review the patch and here are a few
comments:
* Given the timeline for a Geode release why not JDK 8 instead of 7 in the
image ?
* As I did on the Dockerfile I'd rather have an environment variable with JAVA
version and HOME so it's easier to maintain and update the Dockerfile for new
releases.
* In the Dockerfile, no need for echo "export PATH=$PATH:$JAVA_HOME/bin" >>
~/.bashrc - Dockerfiles already have an specific section for ENV variables -
(ENV JAVA_HOME /jdk1.8.0_51)
* The same applies for the stuff I've removed from the JDK that we don't need,
in order to make the image smaller. Stuff like mission control libs, javafx,
etc.. Also for the OS unnecessary packages.
* About the OS, no reason to use Centos 6, it's very old... We should go for
Centos 7 at minimal.
* Finally, when this is done we should push that image to Dockerhub. That will
make things easier if we decide to do builds somewhere else or reuse the base
image. other than Jenkins/ASF like AWS, etc..
In summary, is there anything missing on the Dockerfile I've shared in a
previous comment ? Maybe you can use that as a base or as is ?
Thanks!
> Geode build environment within Docker to enable anybody and on any OS and any
> environment can build Geode as long as there is Docker
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GEODE-60
> URL: https://issues.apache.org/jira/browse/GEODE-60
> Project: Geode
> Issue Type: Sub-task
> Components: build
> Reporter: jun aoki
> Assignee: jun aoki
> Attachments: GEODE-60-2.patch, GEODE-60-3.patch, GEODE-60-4.patch,
> GEODE-60.patch
>
>
> geode build is on gradle and seems very tidy but it still requires third
> party libraries, like Java.
> Let's have a Docker environment so that at least we have an reliable
> immutable environment and we can use it on CI on builds.apache.org
> https://builds.apache.org/view/E-G/view/Geode/
> (From my experience, It is a bit of pain to find a right environment on
> builds.a.o but Docker is a cure so far.)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
