[ 
https://issues.apache.org/jira/browse/GEODE-874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123908#comment-15123908
 ] 

ASF GitHub Bot commented on GEODE-874:
--------------------------------------

Github user upthewaterspout commented on the pull request:

    https://github.com/apache/incubator-geode/pull/82#issuecomment-176894749
  
    You changed these to be ./gradle. I don't think that makes sense. Either 
someone is using the gradle wrapper - './gradlew' - or they are using in 
installed copy of gradle, in which case they would do 'gradle" (no ./)
    
    Dockerfile is script, and it starts by clone the repo. So ./gradlew is the 
appropriate thing do there.
    
    I do wonder how many people will use the source distro vs. just cloning the 
repo from github. For most people, ./gradlew is the easiest and correct thing 
to do.
    



> v1.0.0-incubating.M1.RC2: Text file errors in the source distribution
> ---------------------------------------------------------------------
>
>                 Key: GEODE-874
>                 URL: https://issues.apache.org/jira/browse/GEODE-874
>             Project: Geode
>          Issue Type: Bug
>          Components: docs
>            Reporter: Kenneth Howe
>            Assignee: Kenneth Howe
>
> gradlew script is not included in the Geode release packages, but it is 
> called out in command examples in the following text files in the release 
> source distribution:
> COMPILING.txt
> RUNNING.txt
> docker/Dockerfile
> gemfire-spark-connector/doc/1_building.md
> The easy fix is to change "gradlew" to "gradle" in affected files and include 
> a requirement for the user to install gradle from gradle.org.
> There was a similar issue with README.md that was fixed for RC2.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to