[
https://issues.apache.org/jira/browse/GEODE-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143990#comment-15143990
]
ASF subversion and git services commented on GEODE-26:
------------------------------------------------------
Commit ee7b041adb7be0debc16e631ca4024b8d8652d53 in incubator-geode's branch
refs/heads/develop from [~amb]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=ee7b041 ]
GEODE-26: Remove mavenLocal from repositories
> Apache Geode 'build.gradle' inappropriately declares mavenLocal() in
> Repository declarations.
> ---------------------------------------------------------------------------------------------
>
> Key: GEODE-26
> URL: https://issues.apache.org/jira/browse/GEODE-26
> Project: Geode
> Issue Type: Bug
> Components: build
> Affects Versions: 1.0.0-incubating
> Environment: Any Gradle capable env for building Apache Geode.
> Reporter: John Blum
> Assignee: Mark Bretl
> Priority: Critical
> Labels: ApacheGeode, Gradle, Repositories, build.gradle,
> mavenLocal()
>
> In the
> [build.gradle|https://github.com/apache/incubator-geode/blob/master/build.gradle#L9-10]
> file of the _Apache Geode_ project, the {{repositories}} declaration
> inappropriately contains {{mavenLocal()}}.
> The problem with this is, if developers contributing patches to the _Apache
> Geode_ codebase inadvertently include a "local" dependency to the
> dependencies defined in Geode's {{build.gradle}} file(s), then Geode will
> build locally but not when the patch is submitted and Geode's build
> infrastructure runs the same build with the code changes dependent on the
> (possibly) non-existent, non-resolvable dependency, because, it only exists
> in the developers "local" Maven (env) repository ({{~/.m2/repository}}).
> There are other preferred ways in which users can specify the use of
> {{mavenLocal()}} to affect their work _Apache Geode_ codebase/build without
> modifying the actual _Apache Geode_ {{build.gradle}} file.
> For instance, a developer can created a {{~/.gradle/init.gradle}} script to
> tweak "available" Repositories, like so...
> {code:xml}
> allprojects {
> repositories {
> mavenLocal()
> maven { url "http://maven.domain.com/path/to/another/maven/repo"}
> // etc...
> }
> }
> {code}
> See the [Gradle documentation on
> init.scripts|https://docs.gradle.org/current/userguide/init_scripts.html] for
> more details.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)