[
https://issues.apache.org/jira/browse/GEODE-1120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220726#comment-15220726
]
Hitesh Khamesra commented on GEODE-1120:
----------------------------------------
I looked that piece of code and agree that class is not thread safe. Infact
whole block(header+body) is not synchronized.
> Synchronization on local variables in Message
> ---------------------------------------------
>
> Key: GEODE-1120
> URL: https://issues.apache.org/jira/browse/GEODE-1120
> Project: Geode
> Issue Type: Improvement
> Components: messaging
> Reporter: Robert Geiger
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Message.java
> and extending classes (ChunkedMessage) have synchronization statements that
> appear to have the purpose of making the comm buffer use safe for read/write
> from different threads. The class however is clearly not thread safe, and
> synchronization is done on local variables in multiple places and so is
> incorrect.
> If there is a defined purpose for the synchronization it should be done
> correctly; if not it should be removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
