[ 
https://issues.apache.org/jira/browse/GEODE-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15246706#comment-15246706
 ] 

ASF subversion and git services commented on GEODE-1190:
--------------------------------------------------------

Commit 58caa328a6eabc2a33cbb8b834340a2272e1f1aa in incubator-geode's branch 
refs/heads/develop from [~nnag]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=58caa32 ]

GEODE-1190: LuceneServiceProvider.get now accepts GemFireCache as a parameter.

* Modified the LuceneServiceProvider.get function signature to use GemFireCache 
as a parameter.
* Wrote a small test case to check that LuceneServiceProvider.get does not 
return null when ClientCache is passed as a parameter.

This closes #129


> Should the LuceneServiceProvider get API take a GemFireCache instead of a 
> Cache?
> --------------------------------------------------------------------------------
>
>                 Key: GEODE-1190
>                 URL: https://issues.apache.org/jira/browse/GEODE-1190
>             Project: Geode
>          Issue Type: Bug
>          Components: lucene
>            Reporter: Barry Oglesby
>
> Should the LuceneServiceProvider get API take a GemFireCache instead of a 
> Cache?
> The {{LuceneServiceProvider get}} API takes a {{Cache}} like:
> {noformat}
> public static LuceneService get(Cache cache)
> {noformat}
> If I create a {{ClientCache}}, I can't pass that into this method.
> Code like this doesn't compile:
> {noformat}
> ClientCache cache = new ClientCacheFactory().create();
> LuceneService luceneService = LuceneServiceProvider.get(cache);
> {noformat}
> Instead I have to cast the {{ClientCache}} to a {{Cache}}, but that doesn't 
> seem right:
> {noformat}
> ClientCache clientCache = new ClientCacheFactory().create();
> LuceneService luceneService = LuceneServiceProvider.get((Cache) clientCache);
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to