[
https://issues.apache.org/jira/browse/GEODE-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15250347#comment-15250347
]
ASF GitHub Bot commented on GEODE-1059:
---------------------------------------
GitHub user nabarunnag opened a pull request:
https://github.com/apache/incubator-geode/pull/132
GEODE-1059: PRQueryDUnitHelper no longer inherits
PartitionedRegionDUnitTestCase
* PRQueryDUnitHelper class no longer inherits
PartitionedRegionDUnitTestCase hence no more calls to its constructor.
* All the methods for creating PortfolioData elements were moved to Utils
class.
* Removed the file PRQueryPerfDUnitTest.java
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-1059
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/132.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #132
----
----
> QueryREUpdateInProgressJUnitTest needs should not instantiate PRQueryHelper
> ---------------------------------------------------------------------------
>
> Key: GEODE-1059
> URL: https://issues.apache.org/jira/browse/GEODE-1059
> Project: Geode
> Issue Type: Improvement
> Components: querying
> Reporter: Jason Huynh
> Assignee: Jason Huynh
> Labels: CI, Flaky
>
> Currently tests in this class are using PRQueryHelper. PRQueryHelper itself
> is a DUnit test, this ends up creating the dunit vms even though the original
> test does not require these vms.
> Instead the helper code that is being used (in this case, creation of
> Portfolio objects) can be copied/moved over to the JUnit test itself.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
