[
https://issues.apache.org/jira/browse/GEODE-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258277#comment-15258277
]
ASF subversion and git services commented on GEODE-1237:
--------------------------------------------------------
Commit 872f955c491b6ec3e3881be2d7f0c1d192478aee in incubator-geode's branch
refs/heads/feature/GEODE-17-2 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=872f955 ]
GEODE-1237 remove the check for network-partition-detection uniformity
Each member now determines whether to force shutdown due to loss of quorum.
They also decide whether locators are preferred as membership coordinators.
This primarily meant removing the method GMSJoinLeave
.inheritSettingsFromLocator() but the ID settings needed to be made in
other places (JGroupsMessenger.establishLocalAddress() and
GMSJoinLeave.started()).
I also noticed that some of the code was still using "splitBrain" and
"SB" instead of networkPartitionDetection and "NPD" and fixed that.
One test had to be removed from LocatorDUnitTest and a couple of others
needed to be adjusted to have all of the members set network-partition
-detection-enabled=true. Precheckin is running and I'll fix any other
tests that have this problem.
> remove the check for network-partition-detection uniformity
> -----------------------------------------------------------
>
> Key: GEODE-1237
> URL: https://issues.apache.org/jira/browse/GEODE-1237
> Project: Geode
> Issue Type: Bug
> Components: membership
> Reporter: Bruce Schuchardt
> Assignee: Bruce Schuchardt
>
> There is currently a check in the membership system that rejects a new member
> if it has a different setting for network-partition-detection. This makes it
> impossible to change this setting in a running system by doing a rolling
> upgrade. There's no reason to require this uniformity with the quorum-based
> network partition detection so this check should be removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
