Kirk Lund created GEODE-1322:
--------------------------------

             Summary: Cleanup session replication integration tests
                 Key: GEODE-1322
                 URL: https://issues.apache.org/jira/browse/GEODE-1322
             Project: Geode
          Issue Type: Test
          Components: tests
            Reporter: Kirk Lund


Cleanup tests in extensions/geode-modules and extensions/geode-modules-tomcat7.

These two tests are currently annotated as UnitTest but should be 
IntegrationTest:
* Tomcat6SessionsJUnitTest
* Tomcat7SessionsJUnitTest

The above need to be changed to IntegrationTest and use a TemporaryFolder Rule. 
The above two fail in some weird and unexpected ways. For example, you cannot 
currently run either with "./gradlew -Dtest.single=Tomcat6SessionsJUnitTest 
extensions/geode-modules:test" and I'm not sure why not.

This test currently uses a really old custom PerTestClassLoaderRunner which 
does not support Rules (and it needs to use a TemporaryFolder Rule as well -- 
currently it uses java.io.tmpdir):
* SessionReplicationIntegrationJUnitTest

In order to recategorize the above two, we need to move the 
src/test/resources/tomcat under extensions/geode-modules to 
src/integrationTest/resources/tomcat. Without moving it these tests fail when 
recategorized as IntegrationTest with:

{noformat}
org.apache.catalina.LifecycleException: Failed to start component 
[StandardService[null]]
        at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:154)
        at 
com.gemstone.gemfire.modules.session.EmbeddedTomcat.startContainer(EmbeddedTomcat.java:126)
        at 
com.gemstone.gemfire.modules.session.TestSessionsBase.setupServer(TestSessionsBase.java:67)
        at 
com.gemstone.gemfire.modules.session.Tomcat7SessionsJUnitTest.setupClass(Tomcat7SessionsJUnitTest.java:30)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:497)
        at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
        at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
        at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
        at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
        at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
        at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
        at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:105)
        at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
        at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
        at 
org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:497)
        at 
org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
        at 
org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
        at 
org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
        at 
org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
        at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
        at 
org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:497)
        at 
org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
        at 
org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
        at 
org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360)
        at 
org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
        at 
org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
        at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)
Caused by: com.gemstone.gemfire.GemFireIOException: Could not open log file 
"/data/jenkins/workspace/GEM-patch-build-closed/gemfire/open/extensions/geode-modules-tomcat7/build/integrationTest/tomcat/logs/gemfire_modules.2016-04-28.log".
        at 
com.gemstone.gemfire.internal.logging.log4j.LogWriterAppenders.createLogWriterAppender(LogWriterAppenders.java:182)
        at 
com.gemstone.gemfire.internal.logging.log4j.LogWriterAppenders.getOrCreateAppender(LogWriterAppenders.java:87)
        at 
com.gemstone.gemfire.internal.logging.log4j.LogWriterAppenders.getOrCreateAppender(LogWriterAppenders.java:105)
        at 
com.gemstone.gemfire.distributed.internal.InternalDistributedSystem.initialize(InternalDistributedSystem.java:563)
        at 
com.gemstone.gemfire.distributed.internal.InternalDistributedSystem.newInstance(InternalDistributedSystem.java:278)
        at 
com.gemstone.gemfire.distributed.DistributedSystem.connect(DistributedSystem.java:1631)
        at com.gemstone.gemfire.cache.CacheFactory.create(CacheFactory.java:226)
        at 
com.gemstone.gemfire.modules.session.bootstrap.PeerToPeerCache.createOrRetrieveCache(PeerToPeerCache.java:59)
        at 
com.gemstone.gemfire.modules.session.bootstrap.AbstractCache.lifecycleEvent(AbstractCache.java:82)
        at 
com.gemstone.gemfire.modules.session.catalina.AbstractCacheLifecycleListener.lifecycleEvent(AbstractCacheLifecycleListener.java:31)
        at 
org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:119)
        at 
org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:90)
        at 
org.apache.catalina.util.LifecycleBase.setStateInternal(LifecycleBase.java:401)
        at 
org.apache.catalina.util.LifecycleBase.setState(LifecycleBase.java:346)
        at org.apache.catalina.startup.Embedded.startInternal(Embedded.java:773)
        at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150)
        ... 39 more
Caused by: java.io.FileNotFoundException: 
/data/jenkins/workspace/GEM-patch-build-closed/gemfire/open/extensions/geode-modules-tomcat7/build/integrationTest/tomcat/logs/gemfire_modules.2016-04-28.log
 (No such file or directory)
        at java.io.FileOutputStream.open0(Native Method)
        at java.io.FileOutputStream.open(FileOutputStream.java:270)
        at java.io.FileOutputStream.<init>(FileOutputStream.java:213)
        at 
com.gemstone.gemfire.internal.logging.log4j.LogWriterAppenders.createLogWriterAppender(LogWriterAppenders.java:179)
        ... 54 more
{noformat}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to