[
https://issues.apache.org/jira/browse/GEODE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15291892#comment-15291892
]
ASF GitHub Bot commented on GEODE-1296:
---------------------------------------
Github user dschneider-pivotal commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/145#discussion_r63931246
--- Diff:
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStoredObjectJUnitTest.java
---
@@ -816,6 +820,7 @@ public void
getRawBytesShouldThrowExceptionIfValueIsCompressed() {
chunk.getRawBytes();
chunk.release();
+ fail("Expected getRawBytes() for a compressed value to throw
java.lang.AssertionError");
--- End diff --
Why is this "fail" call added. Doesn't the "expected" on the Test
annotation take care of this?
> OffHeapStoredObject.getRawBytes should assert that it is not called on
> compressed data
> --------------------------------------------------------------------------------------
>
> Key: GEODE-1296
> URL: https://issues.apache.org/jira/browse/GEODE-1296
> Project: Geode
> Issue Type: Bug
> Components: offheap
> Reporter: Darrel Schneider
> Assignee: Kenneth Howe
>
> The current code does this:
> if (isCompressed()) {
> throw new UnsupportedOperationException();
> }
> It would be more clear if it just did this:
> assert !isCompressed();
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
