[ 
https://issues.apache.org/jira/browse/GEODE-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15298706#comment-15298706
 ] 

ASF subversion and git services commented on GEODE-1289:
--------------------------------------------------------

Commit 3ebcf1f750f3692179219b80737a39289d90c72d in incubator-geode's branch 
refs/heads/feature/GEODE-1153 from [~dschneider]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=3ebcf1f ]

GEODE-1289: remove @Retained from getValueInVM

@Retained has been removed from the getValueInVM declaration
and callers have been changed to no longer act as if the result
of getValueInVM might be off-heap.


> RegionEntry.getValueInVM result should not be @Retained
> -------------------------------------------------------
>
>                 Key: GEODE-1289
>                 URL: https://issues.apache.org/jira/browse/GEODE-1289
>             Project: Geode
>          Issue Type: Bug
>          Components: offheap
>            Reporter: Darrel Schneider
>            Assignee: Darrel Schneider
>             Fix For: 1.0.0-incubating.M3
>
>
> The method RegionEntry.getValueInVM has its result marked as @Retained.
> However the implementation always copies the result to the heap (see 
> AbstractRegionEntry.getValueInVM which uses copyAndReleaseIfNeeded).
> All the callers of this method need to also be checked because many of them 
> also say they are @Retained and they even have try/finally code to do a 
> release that is not needed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to