[
https://issues.apache.org/jira/browse/GEODE-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15358023#comment-15358023
]
ASF GitHub Bot commented on GEODE-1452:
---------------------------------------
GitHub user gracemeilen opened a pull request:
https://github.com/apache/incubator-geode/pull/184
GEODE-1452 Add @Ignore to disabled tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gracemeilen/incubator-geode
feature/GEODE-1452-3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/184.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #184
----
commit d008a428b8e92ba454cfc4f7022559d394c9c1b4
Author: gmeilen <[email protected]>
Date: 2016-06-30T23:11:12Z
GEODE-1452 Add @Ignore to disabled tests
----
> Annotate disabled test methods with @Ignore
> -------------------------------------------
>
> Key: GEODE-1452
> URL: https://issues.apache.org/jira/browse/GEODE-1452
> Project: Geode
> Issue Type: Test
> Components: tests
> Reporter: Kirk Lund
> Assignee: Kirk Lund
>
> Some of the older tests have test methods which were disabled by renaming the
> test method from JUnit 3 syntax to something like "public void _testMethod"
> or "public void disabled_testMethod".
> Most of these tests were then updated to JUnit 4, but the disabled tests
> remain without @Ignore or @Test annotations.
> We should annotate these test methods with @Ignore and @Test so they are
> correctly counted as skipped tests. Tickets should then be filed to analyze
> whether these tests should be fixed or deleted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
