[
https://issues.apache.org/jira/browse/GEODE-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15358093#comment-15358093
]
ASF GitHub Bot commented on GEODE-11:
-------------------------------------
Github user nabarunnag commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/177#discussion_r69231478
--- Diff:
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
---
@@ -77,13 +77,13 @@ public void initialize() {
final String fileRegionName = createFileRegionName();
PartitionAttributes partitionAttributes =
dataRegion.getPartitionAttributes();
if (!fileRegionExists(fileRegionName)) {
- fileRegion = createFileRegion(regionShortCut, fileRegionName,
partitionAttributes);
+ fileRegion = createFileRegion(regionShortCut, fileRegionName,
partitionAttributes, ra);
--- End diff --
Its a nitpicky stuff but can we rename ra as regionAttributes. Just to keep
things uniform... all other variables have full explanation names like
regionShortcut, fileRegionName but just "ra" is the extra short one.
> Lucene Integration
> ------------------
>
> Key: GEODE-11
> URL: https://issues.apache.org/jira/browse/GEODE-11
> Project: Geode
> Issue Type: New Feature
> Components: querying
> Reporter: Dan Smith
> Assignee: xiaojian zhou
>
> This is a feature that has been under development for GemFire but was not
> part of the initial drop of code for geode.
> Allow Lucene indexes to be stored in Geode regions allowing users to do text
> searches on data stored in Geode.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
