[
https://issues.apache.org/jira/browse/GEODE-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406350#comment-15406350
]
ASF GitHub Bot commented on GEODE-1712:
---------------------------------------
GitHub user gracemeilen opened a pull request:
https://github.com/apache/incubator-geode/pull/226
GEODE-1712: introduce SecurityService interface for mocking
GEODE-1712: add missing categories and fix test failure
* fix changes recommended in review
GEODE-1712: add static factory methods to SecurityService
GEODE-1713: cleanup imports
GEODE-1712: introduce SecurityService interface for mocking
* create Unit Tests for client commands that use security
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gracemeilen/incubator-geode
feature/GEODE-1712-3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/226.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #226
----
commit 449e5c4c3dcc26b982fa822b9a8d210c6dd9732d
Author: gmeilen <[email protected]>
Date: 2016-07-18T20:13:11Z
GEODE-1712: introduce SecurityService interface for mocking
* create Unit Tests for client commands that use security
commit b136c20417bdff2b9e7c6778471b12f48e2aedd2
Author: gmeilen <[email protected]>
Date: 2016-07-28T17:46:30Z
GEODE-1713: cleanup imports
commit b549bcc14ee2eeb1c0d5895965b3082875219fa5
Author: gmeilen <[email protected]>
Date: 2016-07-28T20:20:23Z
GEODE-1712: add static factory methods to SecurityService
commit cb08cfcee874fe67e5a64518e08b7e517d59f04c
Author: gmeilen <[email protected]>
Date: 2016-08-03T18:15:55Z
GEODE-1712: add missing categories and fix test failures
----
> Need unit tests for classes using Integrated Security
> -----------------------------------------------------
>
> Key: GEODE-1712
> URL: https://issues.apache.org/jira/browse/GEODE-1712
> Project: Geode
> Issue Type: Test
> Components: tests
> Affects Versions: 1.0.0-incubating.M1
> Reporter: Grace Meilen
> Assignee: Grace Meilen
> Labels: security
>
> Most of the classes using Integrated Security (GEODE-17) do not have Unit
> Tests (some have Integrated Test coverage).
> We need to wrap GeodeSecurityUtil in an interface (SecurityService) that can
> be mocked so it's possible to write Unit Tests for all of the classes using
> Integrated Security.
> Client command classes that need Unit Tests:
> * CommitCommand
> * ContainsKey
> * ContainsKey66
> * CreateRegion
> * Destroy65
> * DestroyRegion
> * Destroy
> * ExecuteFunction65
> * ExecuteFunction66
> * ExecuteFunction
> * Get70
> * GetAll70
> * GetAll651
> * GetAll
> * GetAllWithCallback
> * GetClientPartitionAttributesCommand66
> * GetClientPartitionAttributesCommand
> * Invalidate
> * KeySet
> * Put61
> * Put65
> * Put
> * RegisterInterest61
> * RegisterInterestList61
> * RegisterInterestList66
> * RegisterInterest
> * RemoveAll
> * Request
> * UnregisterInterest
> Non-core client command classes needing Unit Tests:
> * CloseCQ
> * ExecuteCQ
> * ExecuteCQ61
> * GetCQStats
> * GetDurableCQs
> * MonitorCQ
> * StopCQ
> More classes needing Unit Tests:
> * AcceptorImpl
> * CacheClientProxy
> * HandShake
> * ServerConnection
> * CreateAllterDestroyRegionCommands
> * DataCommands
> * IndexCommands
> * DataCommandFunction
> * CommandProcessor
> * AccessControlMBean
> * MBeanServerWrapper
> * LoginHandlerInterceptor
> * LuceneIndexCommands
> * SystemManagementService
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
