[ 
https://issues.apache.org/jira/browse/GEODE-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436025#comment-15436025
 ] 

ASF subversion and git services commented on GEODE-1811:
--------------------------------------------------------

Commit 91cca477fd4edf6eea72bbc64ddfea40bb34e89a in incubator-geode's branch 
refs/heads/feature/GEODE-420 from [~upthewaterspout]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=91cca47 ]

GEODE-1811: Marking runtime dependencies as optional in the pom

We had certain runtime dependencies marked as optional in
geode-core/build.gradle. However, we were only looking for the optional
flag on compile dependencies, so the runtime dependencies were not
marked as optional in the generated pom file.


> Runtime dependencies listed as optional in build.gradle are not optional in 
> the pom
> -----------------------------------------------------------------------------------
>
>                 Key: GEODE-1811
>                 URL: https://issues.apache.org/jira/browse/GEODE-1811
>             Project: Geode
>          Issue Type: Bug
>          Components: build
>            Reporter: Dan Smith
>            Assignee: Dan Smith
>             Fix For: 1.0.0-incubating
>
>
> We added a flag to mark dependencies as optional in build gradle, using 
> ext.optional. We've added that flag to several dependencies in build.gradle.
> Unfortunately, we were only honoring the flag for compile dependencies, not 
> runtime dependencies. So with geode M3, the following dependencies are still 
> not optional at runtime, even though they are marked as optional in 
> geode-core/build.gradle.
> {code}
>     <dependency>
>       <groupId>org.fusesource.jansi</groupId>
>       <artifactId>jansi</artifactId>
>       <version>1.8</version>
>       <scope>runtime</scope>
>       <optional>true</optional>
>     </dependency>
>     <dependency>
>       <groupId>org.apache.logging.log4j</groupId>
>       <artifactId>log4j-slf4j-impl</artifactId>
>       <version>2.6.1</version>
>       <scope>runtime</scope>
>       <optional>true</optional>
>     </dependency>
>     <dependency>
>       <groupId>org.apache.logging.log4j</groupId>
>       <artifactId>log4j-jcl</artifactId>
>       <version>2.6.1</version>
>       <scope>runtime</scope>
>       <optional>true</optional>
>     </dependency>
>     <dependency>
>       <groupId>org.apache.logging.log4j</groupId>
>       <artifactId>log4j-jul</artifactId>
>       <version>2.6.1</version>
>       <scope>runtime</scope>
>       <optional>true</optional>
>     </dependency>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to