[
https://issues.apache.org/jira/browse/GEODE-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Huynh resolved GEODE-1757.
--------------------------------
Resolution: Invalid
Closing this ticket, missed an early return statement that does not set status
but returns true.
> initializeProxy method in CacheClientNotifier only returns false
> ----------------------------------------------------------------
>
> Key: GEODE-1757
> URL: https://issues.apache.org/jira/browse/GEODE-1757
> Project: Geode
> Issue Type: Bug
> Components: client queues
> Reporter: Jason Huynh
>
> The following method will always return false. We should take a look to see
> what this actually means for the product. It would be a bit unnecessary if
> it was intended...
> private boolean initializeProxy(CacheClientProxy l_proxy) throws IOException,
> CacheException {
> boolean status = false;
> if (!this.isProxyInInitializationMode(l_proxy)){
> if (logger.isDebugEnabled()) {
> logger.debug("Initializing proxy: {}", l_proxy);
> }
> try {
> // Add client proxy to initialization list. This has to be done
> before
> // the queue is created so that events can be buffered here for
> delivery
> // to the queue once it's initialized (bug #41681 and others)
> addClientInitProxy(l_proxy);
> l_proxy.initializeMessageDispatcher();
> // Initialization success. Add to client proxy list.
> addClientProxy(l_proxy);
> return true;
> } catch (RegionExistsException ree) {
> if (logger.isDebugEnabled()) {
> String name = ree.getRegion() != null ?
> ree.getRegion().getFullPath() : "null region";
> logger.debug("Found RegionExistsException while initializing proxy.
> Region name: {}", name);
> }
> // This will return false;
> } finally {
> removeClientInitProxy(l_proxy);
> }
> }
> return status;
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
