[
https://issues.apache.org/jira/browse/GEODE-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530321#comment-15530321
]
ASF subversion and git services commented on GEODE-1945:
--------------------------------------------------------
Commit 8c7efba86bcc8b6bc7009e75737e591b9f5afc4f in incubator-geode's branch
refs/heads/develop from [[email protected]]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=8c7efba ]
GEODE-1945: split and refactor JSSESocketJUnitTest
The testing for ClientSocketFactory is extracted into the new test
ClientSocketFactoryIntegrationTest. Test has been updated to use
AssertJ and Rules.
The testing for SocketCreatorFactory and SSL is extract into the
new test SSLSocketIntegrationTest. Test has been updated to be more
readable and to use AssertJ, Awaitility and Rules.
> JSSESocketJUnitTest needs to be refactored
> ------------------------------------------
>
> Key: GEODE-1945
> URL: https://issues.apache.org/jira/browse/GEODE-1945
> Project: Geode
> Issue Type: Test
> Components: tests
> Reporter: Kirk Lund
> Assignee: Kirk Lund
>
> JSSESocketJUnitTest contains two tests which are unrelated and do not share
> the same test fixture. These should be split out into two different tests.
> The first test in JSSESocketJUnitTest also jumps through a lot of hoops just
> to capture and assert some debug log statements. This has no value.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
