[
https://issues.apache.org/jira/browse/GEODE-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15536847#comment-15536847
]
ASF GitHub Bot commented on GEODE-1907:
---------------------------------------
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/249#discussion_r81404596
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/beans/QueryDataFunction.java
---
@@ -360,31 +373,36 @@ public static Object queryData(final String query,
for (String regionPath : regionsInQuery) {
DistributedRegionMXBean regionMBean =
service.getDistributedRegionMXBean(regionPath);
if (regionMBean == null) {
- return new
JsonisedErroMessage(ManagementStrings.QUERY__MSG__REGIONS_NOT_FOUND.toLocalizedString(regionPath)).toString();
+ return new
JsonisedErroMessage(ManagementStrings.QUERY__MSG__REGIONS_NOT_FOUND.toLocalizedString(regionPath))
+ .toString();
} else {
Set<DistributedMember> associatedMembers =
DataCommands.getRegionAssociatedMembers(regionPath, cache, true);
if (inputMembers != null && inputMembers.size() > 0) {
if (!associatedMembers.containsAll(inputMembers)) {
- return new
JsonisedErroMessage(ManagementStrings.QUERY__MSG__REGIONS_NOT_FOUND_ON_MEMBERS.toLocalizedString(regionPath))
- .toString();
+ return new
JsonisedErroMessage(ManagementStrings.QUERY__MSG__REGIONS_NOT_FOUND_ON_MEMBERS
+ .toLocalizedString(regionPath)).toString();
}
}
}
}
} else {
- return new
JsonisedErroMessage(ManagementStrings.QUERY__MSG__INVALID_QUERY.toLocalizedString("Region
mentioned in query probably missing /")).toString();
+ return new
JsonisedErroMessage(ManagementStrings.QUERY__MSG__INVALID_QUERY.toLocalizedString("Region
mentioned in query probably missing /"))
+ .toString();
}
// Validate
if (regionsInQuery.size() > 1 && inputMembers == null) {
for (String regionPath : regionsInQuery) {
DistributedRegionMXBean regionMBean =
service.getDistributedRegionMXBean(regionPath);
- if
(regionMBean.getRegionType().equals(DataPolicy.PARTITION.toString()) ||
-
regionMBean.getRegionType().equals(DataPolicy.PERSISTENT_PARTITION.toString()))
{
- return new
JsonisedErroMessage(ManagementStrings.QUERY__MSG__JOIN_OP_EX.toLocalizedString()).toString();
+ if (regionMBean.getRegionType()
--- End diff --
I updated the formatters in etc/ including etc/intellijIdeaCodeStyle.xml to
prevent these whacky linefeeds. Please update and rerun the formatter. The
changes look good and I'll pull it in as soon as you've reformatted. Thanks!
> QueryDataFunction does not add LIMIT clause if space is missing after FROM
> clause
> ---------------------------------------------------------------------------------
>
> Key: GEODE-1907
> URL: https://issues.apache.org/jira/browse/GEODE-1907
> Project: Geode
> Issue Type: Bug
> Components: management, querying
> Reporter: Kirk Lund
> Assignee: Jared Stewart
> Priority: Minor
>
> Apparently "SELECT * FROM/MyRegion" is a valid query in Geode, however if
> this query is used from GFSH or Pulse, then QueryDataFunction will fail to
> add a LIMIT clause because there is no space between FROM and the region name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
