[
https://issues.apache.org/jira/browse/GEODE-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15547060#comment-15547060
]
ASF GitHub Bot commented on GEODE-136:
--------------------------------------
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/252
GEODE-136: Fix possible NullPointerException in GetRegionsFunction
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kjduling/incubator-geode feature/GEODE-136
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/252.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #252
----
commit 56a35e2b60c9a039dda06e5af7c0af431e8d3096
Author: Anthony Baker <aba...@apache.org>
Date: 2016-10-01T16:22:25Z
Bump version after creating release/1.0.0-incubating branch
commit e04519dc3eced1254f58eaebee9c241ee335dbab
Author: Jinmei Liao <jil...@pivotal.io>
Date: 2016-10-03T17:51:05Z
GEODE-420: fix Pulse test when not using any SSLConfig
commit 8929e93bd129b303aae8f9e1b13daf3c3991d1a4
Author: Anthony Baker <aba...@apache.org>
Date: 2016-10-01T23:55:44Z
Add FlakyTest category to tests with open bugs
Annotate test methods with FlakyTest category if there is an open
bug for that test. This will improve the signal/noise ratio for
unit/integration/distributed tests. Flaky tests are still run
as part of precheckin and flakyTest targets.
commit c80cba2c81f55736121a0d12d7e01b3249c20bdd
Author: Kevin Duling <kdul...@pivotal.io>
Date: 2016-09-26T23:10:34Z
GEODE-1902 - Add GEMFIRE_VERBOSE LogMarker as alias of GEODE_VERBOSE for
backwards compatibility
This closes #247
commit 8703f2a71526a35f8945698611d18a0b8b9bd373
Author: Kirk Lund <kl...@apache.org>
Date: 2016-10-04T18:45:46Z
GEODE-1902: reformat code
commit 375c6c5bcf3ee4ab52bb6bf4b34ca3eb26065ef9
Author: Kirk Lund <kl...@apache.org>
Date: 2016-10-04T20:11:03Z
GEODE-1902: add ACCEPT and DENY tests for GEODE_VERBOSE and GEMFIRE_VERBOSE
commit 1feea53c2032bc79df39a653945e53d24f9c9291
Author: Jason Huynh <huyn...@gmail.com>
Date: 2016-10-04T16:31:14Z
GEODE-1963: Add lucene xsd to website content
commit 118c0d467e0ad80d98ff2aaa1a3d22d26b40696f
Author: Kirk Lund <kl...@apache.org>
Date: 2016-10-04T21:38:10Z
GEODE-1902: add apache license header
commit 71627eb8154477c742eb045732967826b2fc1b47
Author: Dave Barnes <dbar...@pivotal.io>
Date: 2016-10-04T22:10:16Z
GEODE-1963 Fix a pathname typo in the website README.md revealed during the
recent lucene.xsd addition.
commit 15a5267c47852efbed14cb9b85614a1208145c33
Author: nabarun <n...@pivotal.io>
Date: 2016-10-04T22:11:30Z
GEODE-1384: Stat issues were fixed as a part of other tickets.
* Code refactored to have the correct order of creation of cache,
region and sender receivers.
commit f0dab0aa3b33306b82ec31ee3fff0cceda1ac719
Author: nabarun <n...@pivotal.io>
Date: 2016-10-04T22:15:23Z
GEODE-1147: Removed flaky class tag
* Test was fixed in a prior commit.
commit f82626f46babe0f5fcce8dafd5deab2ca6b86860
Author: nabarun <n...@pivotal.io>
Date: 2016-10-04T22:26:45Z
GEODE-1804: Refactored the test
* Refactored the test to have the correct order of creation of cache,
region and sender-receivers.
* Additional validity check for the local region size.
commit 0b61ae69d8486c137a30160c22d8985c37f76324
Author: nabarun <n...@pivotal.io>
Date: 2016-10-04T22:33:13Z
GEODE-1364: Resolved as a part of GEODE-1588
commit 18c2dc3fb0067ac529ddd228c746e20f87ac2c9a
Author: nabarun <n...@pivotal.io>
Date: 2016-10-04T22:35:44Z
GEODE-1148: Removing the flaky tag
* Test resolved as a part of prior commit.
commit 3c7f4b7eed8852cd0589ad07ad34824fa2869c68
Author: Kevin Duling <kdul...@pivotal.io>
Date: 2016-10-04T23:39:19Z
GEODE-136: Fix possible NullPointerException in Gfsh's 'list regions'
command's GetRegionsFunction.
----
> Fix possible NullPointerException in Gfsh's 'list regions' command's
> GetRegionsFunction.
> ----------------------------------------------------------------------------------------
>
> Key: GEODE-136
> URL: https://issues.apache.org/jira/browse/GEODE-136
> Project: Geode
> Issue Type: Bug
> Components: gfsh
> Affects Versions: 1.0.0-incubating
> Environment: GemFire Manager + Gfsh
> Reporter: John Blum
> Assignee: Kevin Duling
> Labels: ApacheGeode, CLI, GFSH, GetRegionsFunction, list-regions
> Fix For: 1.0.0-incubating
>
>
> The following line
> ([#48|https://github.com/apache/incubator-geode/blob/develop/gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/GetRegionsFunction.java#L48])
> in the {{GetRegionsFunction}} class could possibly lead to a NPE if the
> {{regions}} _Set_ is null since the {{regions.isEmpty()}} call proceeds the
> {{regions == null}} check.
> Of course, one should argue whether {{Cache.rootRegions()}} should be
> returning a null _Set_ at all rather than an empty _Set_ if there are in fact
> no "root" _Regions_ in the Geode _Cache_.
> But then, one could also argue that this {{GetRegionsFunction}} should not be
> returning a null "array" if there are no "root" _Regions_ in the Geode
> _Cache_ either. It too should be returning an "empty" array.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
