ASF subversion and git services commented on GEODE-1991:

Commit c2ddc96c9e1bbbfaec156e1a9985979bda7b3e36 in incubator-geode's branch 
refs/heads/develop from [~upthewaterspout]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=c2ddc96 ]

GEODE-1991: Removing sleeps from HARegionQueueJUnitTest

Getting rid of a bunch of sleeps in HARegionQueueJUnitTest to fix a
bunch of tests with race conditions. Tests of expiration were sleeping
for short amounts of time and then asserting that expiration happened or
didn't. Changing these sleeps to use Awailitily.

> CI Failure: HARegionQueueJUnitTest.testNoExpiryOfThreadId
> ---------------------------------------------------------
>                 Key: GEODE-1991
>                 URL: https://issues.apache.org/jira/browse/GEODE-1991
>             Project: Geode
>          Issue Type: Bug
>          Components: client queues
>            Reporter: Dan Smith
>              Labels: ci
> This test failed with 9189e3bb95fcd8547327c6047dafea5e0fd76dbb.
> {noformat}
> org.apache.geode.internal.cache.ha.HARegionQueueJUnitTest > 
> testNoExpiryOfThreadId FAILED
>     java.lang.AssertionError:  Expected region size not to be zero since 
> expiry time has not been exceeded but it is not so 
>         at org.junit.Assert.fail(Assert.java:88)
>         at org.junit.Assert.assertTrue(Assert.java:41)
>         at 
> org.apache.geode.internal.cache.ha.HARegionQueueJUnitTest.testNoExpiryOfThreadId(HARegionQueueJUnitTest.java:587)
> {noformat}
> It looks like this is probably just a racy test. It sets an expiration of 3 
> seconds, sleeps for 3 seconds, and expects the entry to not be expired.

This message was sent by Atlassian JIRA

Reply via email to