[
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15648189#comment-15648189
]
ASF GitHub Bot commented on GEODE-1993:
---------------------------------------
Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/276
1. I am using Autowire, the annotation is on the base class's constructor.
But as for the injection via the constructor, please review
https://spring.io/blog/2015/11/29/how-not-to-hate-spring-in-2016 which
references http://olivergierke.de/2013/11/why-field-injection-is-evil/ and
http://docs.spring.io/spring-framework/docs/current/spring-framework-reference/htmlsingle/#beans-constructor-injection
Do you think it would be better to only add the RestSecurityService to the
controllers that actually need it instead of adding it to the base class? I
think that would complicate the constructors.
2 & 3. Agreed, that'll make the test cleaner.
> value returned through /region/key rest service needs to be post processed
> --------------------------------------------------------------------------
>
> Key: GEODE-1993
> URL: https://issues.apache.org/jira/browse/GEODE-1993
> Project: Geode
> Issue Type: New Feature
> Components: management
> Reporter: Jinmei Liao
> Assignee: Kevin Duling
> Fix For: 1.1.0-incubating
>
>
> The new rest security did not use post processor before returning the value
> back to the client.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
