[ 
https://issues.apache.org/jira/browse/GEODE-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-2115:
-----------------------------
    Description: 
GFSH commands with potentially broken error handling:
* MiscellaneousCommands.exportLogs

Command implementation (ie MiscellaneousCommands) may ignore errors returned 
from Function via sendException or lastResult. Function implementation (ie 
LogFileFunction) may fail to invoke sendException for caught exceptions.

Functions under `org.apache.geode.management.internal.cli.functions` should use 
`ResultSend::sendException` to return full stack trace of caught exceptions.

Command implementations should read exceptions returned from functions without 
discarding the info.

  was:
GFSH commands with potentially broken error handling:
* MiscellaneousCommands.exportLogs

Any Function under `org.apache.geode.management.internal.cli.functions` that 
does not call 
`ResultSend::sendException`
is possibly broken, as well as Functions that call `lastResult(e.getMessage())`



> Some GFSH commands may report success even for failures
> -------------------------------------------------------
>
>                 Key: GEODE-2115
>                 URL: https://issues.apache.org/jira/browse/GEODE-2115
>             Project: Geode
>          Issue Type: Bug
>          Components: management
>            Reporter: Jared Stewart
>
> GFSH commands with potentially broken error handling:
> * MiscellaneousCommands.exportLogs
> Command implementation (ie MiscellaneousCommands) may ignore errors returned 
> from Function via sendException or lastResult. Function implementation (ie 
> LogFileFunction) may fail to invoke sendException for caught exceptions.
> Functions under `org.apache.geode.management.internal.cli.functions` should 
> use `ResultSend::sendException` to return full stack trace of caught 
> exceptions.
> Command implementations should read exceptions returned from functions 
> without discarding the info.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to