[ 
https://issues.apache.org/jira/browse/GUACAMOLE-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16761090#comment-16761090
 ] 

Michael Jumper edited comment on GUACAMOLE-478 at 2/5/19 6:32 PM:
------------------------------------------------------------------

{quote}
... parse through the above rdp_client->clipboard->buffer and replace \n with 
\r\n. ...
{quote}

This will break things on any platform that includes "\r\n" in the copied text 
already and may not work on older platforms that use "\r" alone as a line 
ending. The solution to this will need to take variation in line endings into 
account, transforming "\r" or "\n" into "\r\n" when they occur individually 
while also ignoring any existing "\r\n".

As mentioned above, testing against non-Windows RDP servers (XRDP) will also 
need to be done. It has not yet been established that all RDP servers behave 
the same with respect to line endings within clipboard text.


was (Author: mike.jumper):
{quote}
... parse through the above rdp_client->clipboard->buffer and replace \n with 
\r\n. ...
{quote}

This will break things on any platform that includes "\r\n" in the copied text 
already and may not work on older platforms that use "\r" alone as a line 
ending. The solution to this will need to take variation in line endings into 
account, transforming "\r" or "\n" into "\r\n" when they occur individually 
while also ignoring any existing "\r\n".

> RDP clipboard uses incorrect newline characters
> -----------------------------------------------
>
>                 Key: GUACAMOLE-478
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-478
>             Project: Guacamole
>          Issue Type: Bug
>          Components: RDP
>            Reporter: Amarjeet Singh
>            Priority: Minor
>
> With the RDP protocol originating from Windows, the format of text clipboard 
> contents is assumed to use Windows-style newline characters (CR+LF). 
> Guacamole currently does not attempt to translate newline characters, sending 
> the format used within the received clipboard stream. This means that 
> applications running within RDP which only support Windows-style newlines, 
> such as Notepad, fail to handle received clipboard data.
> Applications which can handle both UNIX-style and Windows-style newline 
> characters are unaffected.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to