[
https://issues.apache.org/jira/browse/GUACAMOLE-742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Jumper reopened GUACAMOLE-742:
--------------------------------------
This apparently breaks things on IE 11. Unable to use the login form at all on
a Windows machine with IE, I did a bisect:
{code:none}
[mjumper@dev-mjumper guacamole-client]$ git bisect bad
59fdc80e9f45ac2fc2fcb884ff4900faeb5fabb8 is the first bad commit
commit 59fdc80e9f45ac2fc2fcb884ff4900faeb5fabb8
Author: Michael Jumper <[email protected]>
Date: Sat Apr 27 16:52:37 2019 -0700
GUACAMOLE-742: Provide "disabled" attribute for forms and fields.
:040000 040000 6b96233ffa468480ca32a1672a6f1d2dc28a2f44
d6edbf34ad2a97f2321cbfc0730db33c8b2bf80d M guacamole
[mjumper@dev-mjumper guacamole-client]$ git checkout master
M guacamole/src/main/webapp/app/form/templates/form.html
Previous HEAD position was 59fdc80e9 GUACAMOLE-742: Provide "disabled"
attribute for forms and fields.
Switched to branch 'master'
Your branch is up to date with 'origin/master'.
[mjumper@dev-mjumper guacamole-client]$
{code}
The above commit adds a {{disabled}} attribute to the {{<guac-form-field>}}
directive. While other browsers do not interfere with something like
{{<guac-form-field disabled="disabled">}}, allowing the directive to handle
that attribute itself, IE interprets and applies the {{disabled}} attribute,
disabling all input fields that find their way to the DOM within the directive.
Changing the attribute in the HTML to the alternative {{data-disabled}} form
solves things.
> Display feedback while waiting for login
> ----------------------------------------
>
> Key: GUACAMOLE-742
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-742
> Project: Guacamole
> Issue Type: Improvement
> Components: guacamole
> Reporter: Leigh Bennett
> Assignee: Michael Jumper
> Priority: Trivial
> Fix For: 1.2.0
>
>
> This request is more of a 'nice to have' than anything else. Just something
> I noticed myself and a couple of users have mentioned but after we enter our
> login credentials and hit enter the screen just sits and waits. For users
> that have opted for a code via text its not a problem as we are shown a nice
> little box to enter the code whilst we wait for the text message. This of
> course indicates to the user to that their credentials have been accepted so
> they wait. But for those users that have the push notification app they're
> not actually told anything is happening, so they end up retrying their
> credentials or refreshing the page until they eventually realise their phone
> is going nuts with auth pushes. Eventually they get in of course.
> It would be really nice to have a message that simply displays 'please wait'
> or 'please wait for secondary authentication'. Something along those lines,
> or if its not too much trouble to detect the type of auth then something that
> says 'please check your phone/device' to make it a bit more obvious for these
> poor users using MFA.
> Thank you!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
