[
https://issues.apache.org/jira/browse/GUACAMOLE-853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890305#comment-16890305
]
Michael Jumper commented on GUACAMOLE-853:
------------------------------------------
{quote}
Why i have to create a branch for pull request?
{quote}
>From strictly our side, you don't have to and it makes no difference. Whether
>you use a topic branch has no bearing on review nor on where it gets merged.
On your side, it will make a major difference. It allows you to keep your
changes isolated. Using topic branches is a development best practice. You
don't technically have to, but you would be doing yourself a disservice if you
don't.
https://github.com/dchelimsky/rspec/wiki/Topic-Branches
{quote}
I played a little bit with the translatation files to understand how it work.
Is it possible, that not every area can be translated? For example i translated
the mask to create a new user. Over there is a section with the title "Account
Restrictions". I don't found the required field names in the en.json on my
server or in the latest master on Github.
{quote}
No. With the exception of a few error messages that remain untranslated,
absolutely all text within the web application is driven by translations. It is
possible for extensions to add their own sections/fields/components to the user
interface, in which case they provide their own translations. The "Account
Restrictions" section you refer to is actually defined by the database
authentication extensions, as is the translation for its title:
https://github.com/apache/guacamole-client/blob/20ad54c840ce7599bd1ef511c318e45849310eb0/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/resources/translations/en.json#L100
> Translation do not work correctly
> ---------------------------------
>
> Key: GUACAMOLE-853
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-853
> Project: Guacamole
> Issue Type: Bug
> Components: guacamole
> Affects Versions: 1.0.0
> Environment: Ubuntu 18.04.2 LTS (x64)
> Tomcat 8
> Guacamole 1.0.0
> Reporter: Whitemoon
> Priority: Minor
> Labels: Languages
> Attachments: guacamole-language-english.png,
> guacamole-language-german.png, guacamole-language-italiano.png
>
>
> We use Guacamole with Database Backend (MySQL). We are logged in with the
> default user (=admin) on the web interface. Some menu names (History or
> Grousps) are always in English. I changed the the display language under
> settings.
> The fields (ACTION_MANAGE_USER_GROUPS, ACTION_VIEW_HISTORY) are defined in
> each language file (for example: de.json or it.json).
> Restart of Tomcat and server brought nothing.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
