[ 
https://issues.apache.org/jira/browse/GUACAMOLE-859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16900412#comment-16900412
 ] 

Nick Couchman commented on GUACAMOLE-859:
-----------------------------------------

[~westont]: Great!  Can you submit a pull request under issue GUACAMOLE-801?  I 
still think this likely a duplicate of that, so if you can do that, it would be 
great.  Guidelines for contributing are at 
http://guacamole.apache.org/open-source/ - basically you'll want to:
- Fork the github.com/apache/guacamole-sever repository, and create a branch 
for these changes.
- Make the changes.
- Commit the change, and make sure to tag the commit message with the JIRA 
issue (GUACAMOLE-XXX:)
- Create a pull request, also tagged with the JIRA issue.

> Incorrect Caps Lock keysym sent to Windows via RDP
> --------------------------------------------------
>
>                 Key: GUACAMOLE-859
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-859
>             Project: Guacamole
>          Issue Type: Bug
>    Affects Versions: 1.0.0
>         Environment: macOS Mojave
> Windows 10
>            Reporter: Weston Thayer
>            Priority: Minor
>
> 1. On a Mac, connect to a Windows machine via an RDP connection in Guacamole
> 2. On the Windows machine, open Chrome or Firefox and navigate to 
> https://jsbin.com/reviciceke/2/edit?js,console,output
> 3. Click the "Run with JS" button
> 4. Click the output pane to make sure it has keyboard focus
> 5. Press the Caps Lock key on your Mac (you may need to press it twice if 
> it's already on)
> Actual: The JSBin's console outputs KeyboardEvent.code and KeyboardEvent.key 
> for the "keypress" event. Note how KeyboardEvent.code is an empty string and 
> KeyboardEvent.key is "Unidentified"
> Expected: KeyboardEvent.code should be "CapsLock", as should KeyboardEvent.key
> I believe the keysym being sent by guacamole-common-js's Keyboard.js is 
> 0xffe5. I'm guessing the guacd RDP plugin has a bug, where that keysym is not 
> mapped to the correct RDP scancode(?).
> For reference, using Microsoft's RDP client for macOS, KeyboardEvent.code and 
> key are correctly "CapsLock".
> Note that this bug probably went un-noticed for a long time because Caps Lock 
> still "works" in that future characters typed are capitalized. But in my use 
> case, I need Windows to handle the Caps Lock key down itself.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to