[ https://issues.apache.org/jira/browse/GUACAMOLE-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028640#comment-17028640 ]
Mike Jumper commented on GUACAMOLE-939: --------------------------------------- Yeah, that's pretty much it: * I don't think we should use {{guacamole.properties}} for anything but being {{guacamole.properties}}. It's not a file for defining environment variables. * I definitely don't see an advantage in creating a new way to define environment variables within a file, when there already exists a standard file format and tooling for doing the same and more ({{docker-compose.yml}}). It could be useful to allow the image to consume {{guacamole.properties}} directly. I don't think the image as currently designed makes things any more difficult, though. There is a 1:1 correspondence between lines of {{guacamole.properties}} and environment variables. They equate to the same amount of work whether you maintain them in a non-Docker deployment (using {{guacamole.properties}}) or a Docker deployment (using {{docker-compose.yml}}). > Read Docker image environment variables from guacamole.properties > ----------------------------------------------------------------- > > Key: GUACAMOLE-939 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-939 > Project: Guacamole > Issue Type: Improvement > Components: guacamole-docker > Affects Versions: 1.0.0 > Reporter: Thomas Eggers > Priority: Minor > Attachments: start.sh > > > Hi, > I'm not a Software developer, > but I have linux script and docker experience. > I startet to enhance the start.sh file in the docker image. > This new version is pre read required variable from guacamole.properties to > configure the tomcat web interface. This make it much easier to start the > docker container without so many options. > Other things that I like to do is: > - import certificate for ldaps connections > - docker container health status > - and other small things > Thomas -- This message was sent by Atlassian Jira (v8.3.4#803005)