[
https://issues.apache.org/jira/browse/GUACAMOLE-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085049#comment-17085049
]
Nick Couchman commented on GUACAMOLE-1031:
------------------------------------------
Well...it appears we don't do much with this setting in the RDP code. So, from
VNC, we have this codeblock:
{code:c}
/* Configure destination for basic uploads, if specified */
if (settings->sftp_directory != NULL)
guac_common_ssh_sftp_set_upload_path(
vnc_client->sftp_filesystem,
settings->sftp_directory);
{code}
but, if I look for where {{settings->sftp_directory}} is used in the RDP code,
it's a little thin:
{code:bash}
$ find src/protocols/rdp -type f -iname \*.c -exec grep -H sftp_directory {} \;
src/protocols/rdp/settings.c: settings->sftp_directory =
src/protocols/rdp/settings.c: free(settings->sftp_directory);
src/protocols/rdp/user.c: if (!settings->drive_enabled ||
settings->sftp_directory != NULL)
{code}
The first one deals with parsing the settings, the second with freeing it. And
the third checks if it is set, but there's no indication we do anything with
it! Looks like we're missing the call to
{{guac_common_ssh_sftp_set_upload_path}} in the RDP code.
> SFTP upload directory ignored
> -----------------------------
>
> Key: GUACAMOLE-1031
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-1031
> Project: Guacamole
> Issue Type: Bug
> Components: SSH
> Affects Versions: 1.1.0
> Reporter: Jason Keltz
> Priority: Minor
>
> Hi.
> I have enabled SFTP, configured proper username and password, set the file
> browser root directory, and the upload directory. When the user hits
> CTRL-ALT-SHIFT, the drive icon shows the file browser root directory as
> expected, and the user can upload/download files. If they drag a file from
> their desktop to the RDP session, the file ends up in the root directory.
> I've tried to set the upload directory to "Desktop" to "/Desktop/" and even
> to a full path to Desktop (inside the root) and none work.
> (Using xrdpxorg)
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
