[
https://issues.apache.org/jira/browse/GUACAMOLE-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Jumper reopened GUACAMOLE-103:
-----------------------------------
Assignee: Mike Jumper (was: Nick Couchman)
Minor issue reported by the automated Coverity scan:
{code:none}
*** CID 1464957: Null pointer dereferences (NULL_RETURNS)
/extensions/guacamole-auth-saml/src/main/java/org/apache/guacamole/auth/saml/AuthenticationProviderService.java:
134 in
org.apache.guacamole.auth.saml.AuthenticationProviderService.authenticateUser(org.apache.guacamole.net.auth.Credentials)()
128 }
129
130 // Validate timestamps, generating
ValidationException if this fails.
131 samlResponse.validateTimestamps();
132
133 // Grab the username, and, if present, finish
authentication.
>>> CID 1464957: Null pointer dereferences (NULL_RETURNS)
>>> Calling a method on null object "samlResponse.getNameId()".
134 String username =
samlResponse.getNameId().toLowerCase();
135 if (username != null) {
136
137 // Retrieve any provided attributes
138 Map<String, List<String>> attributes =
139 samlResponse.getAttributes();
{code}
I'll dive in and fix real quick.
> SAML 2.0 support for user authentication
> ----------------------------------------
>
> Key: GUACAMOLE-103
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-103
> Project: Guacamole
> Issue Type: New Feature
> Reporter: Justin P
> Assignee: Mike Jumper
> Priority: Minor
> Fix For: 1.2.0
>
>
> It'd be great if Guacamole supported SAML 2.0 so it could integrate with an
> organization's single sign-on (SSO) solution (especially popular platforms
> like OneLogin, Okta, Bitium, etc.)
> This would make authenticating to Guacamole easier for an organization's
> users, and it would make organization's IT/IS admins happier being able to
> apply authentication security controls to guacamole, such as password
> complexity rules, two-factor authentication rules, etc.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
