[
https://issues.apache.org/jira/browse/GUACAMOLE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152408#comment-17152408
]
Mike Jumper commented on GUACAMOLE-1123:
----------------------------------------
Opened https://github.com/apache/guacamole-client/pull/549 with the above base
changes. With that, assuming {{Connection}} provided a newer version of its old
{{getHistory()}} that returns an appropriate {{ActivityRecordSet}}, exposing
that in the exact same way would be a simple modification to the existing part
of {{ConnectionResource}} that currently returns a {{List}}.
For example, instead of the current:
{code:java}
@GET
@Path("history")
public List<APIConnectionRecord> getConnectionHistory()
throws GuacamoleException {
// Retrieve the requested connection's history
List<APIConnectionRecord> apiRecords = new
ArrayList<APIConnectionRecord>();
for (ConnectionRecord record : connection.getHistory())
apiRecords.add(new APIConnectionRecord(record));
// Return the converted history
return apiRecords;
}
{code}
we could simply have:
{code:java}
@Path("history")
public ConnectionHistoryResource getConnectionHistory()
throws GuacamoleException {
return new ConnectionHistoryResource(connection.getConnectionHistory());
}
{code}
> Standardize on filtered history query for user and connection management
> ------------------------------------------------------------------------
>
> Key: GUACAMOLE-1123
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-1123
> Project: Guacamole
> Issue Type: Improvement
> Components: guacamole, guacamole-auth-jdbc
> Reporter: Nick Couchman
> Assignee: Nick Couchman
> Priority: Minor
>
> When querying connection history, there are several disparate endpoints that
> are used to gather that history. Instead of maintaining these various
> interfaces, we should standardize on a single connection history endpoint and
> update all of the relevant REST calls within the AngularJS application to
> reference those calls.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
