[
https://issues.apache.org/jira/browse/GUACAMOLE-1186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252211#comment-17252211
]
Nick Couchman commented on GUACAMOLE-1186:
------------------------------------------
[~MyJimmy]: I'm reviewing both this issue and your proposed changes, and I have
some concerns about the changes.
First, let me make sure I understand the overall goal of your changes.
Currently, Guacamole forcibly keeps the local clipboard in sync with any/all
remote clipboards, resetting the remote clipboard when focus changes back to
that browser window. Your proposed changes allow for a remote clipboard to stay
"out-of-sync" with the local/Guacamole clipboard, particularly when the remote
clipboard receives data that Guacamole does not support (e.g. images) - at
least until the local clipboard changes, at which point the remote clipboard
gets re-synchronized with the local clipboard, wiping out any changes. Correct?
I did some basic testing with your changes and came up with the following
scenarios and results:
* Text to Local Clipboard: Works as expected, text appears in both local and
remote clipboards and is synchronized.
* Text to Remote Clipboard: Works as expected, text appears in both remote and
local clipboards, and is synchronized.
* Image to Local Clipboard: Works as expected, image is available locally but
not remotely.
* Image to Remote Clipboard: Image remains in remote clipboard as long as
nothing is changed in the local clipboard. However, the local clipboard ends up
cleared/reset. Isn't this just the inverse of the original behavior you were
trying to resolve - we're now keeping the contents of the remote clipboard, but
wiping out anything on the local clipboard?
I did not test situations where multiple remote servers are in use, but I would
imagine that this could very, very quickly get out of hand. I connect to
anywhere from 1 to 10 or 12 remote servers concurrently, and, today, at least I
know what the contents of the clipboard are going to be. It seems like
introducing these changes could lead to a lot of confusion about what remote
servers are actually synced with local clipboard changes and which ones are
ignored, particularly for an end user who will not see warnings in the
Guacamole logs about the missing data format support.
Beyond that, I agree with Mike: this is not a bug. It is intended behavior
based on how Guacamole's clipboard is currently implemented - that is, only
supports texts and endeavors to keep all clipboards synchronized. It seems like
this issue and the changes suggested are really just a work-around for one
corner case that is due to the lack of non-text support in Guacamole, no? If
Guacamole supported rich text and images (from aforementioned Jira issues), and
kept the local clipboard in sync with one or more remote clipboards with that
data, would this even be an issue?
> Clipboard issue that can't paste the image data when changing the focus
> -----------------------------------------------------------------------
>
> Key: GUACAMOLE-1186
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-1186
> Project: Guacamole
> Issue Type: Bug
> Components: guacamole-client, guacamole-server
> Affects Versions: 1.2.0
> Environment: Ubuntu 18.04 64bit, Windows 10 64 bit
> Reporter: Jimmy
> Priority: Minor
> Labels: features
> Attachments: apache-guacd-clipboard-issue.mp4,
> xfreerdp-clipboard-issue.mp4
>
>
> I found one clipboard issue when working on the remote server over the apache
> guacamole client built from the latest source.
>
> The test case follows as below:
> # Connect to the {color:#de350b}*remote server*{color} (Windows 10, 64bit)
> via the Apache Guacamole Client.
> # {color:#de350b}*In the remote server,*{color} open NotePad, type some
> text, press Ctrl+A to select all text, copy it by pressing Ctrl+C.
> # {color:#de350b}*In the remote server,* {color}open WordPad and press
> Ctrl+V to paste the clipboard.
> # {color:#de350b}*In the remote server,* {color}open Paint, draw any shapes,
> press CTrl+A to select all, and press Ctrl+C to copy it.
> # *{color:#de350b}In the remote server,{color}* select WordPad to press
> Ctrl+V to paste the clipboard.
> # *In the client computer,* move the focus from Chrome with the opened
> guacamole client to another application.
> # *In the client computer,* move back to the guacamole client page of Chrome.
> # *In the remote server,* select WordPad to press Ctrl+V to paste the
> clipboard.
>
> In step 8, we can see the issue.
> That's, we can't paste the image, but can paste only the text copied in the
> previous step.
>
> When performed the above test case in the FreeRDP (xfreerdp) and the MS RDP
> client (mstsc.exe), I can't see this issue.
>
> For more information, please see the attached video files.
>
> Thanks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
