[
https://issues.apache.org/jira/browse/GUACAMOLE-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17410183#comment-17410183
]
Nick Couchman commented on GUACAMOLE-1416:
------------------------------------------
[~RyanCai]: Yes, looks like you are correct. I don't think it's all that big a
deal - if it breaks out of there it'll move into the phase of shutting down the
SSH client, so the leak will be short-lived. But it should be cleaned up. Are
you planning to submit a PR for it?
> An improper locking bug(e.g., resource leak) due to unreleased lock
> -------------------------------------------------------------------
>
> Key: GUACAMOLE-1416
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-1416
> Project: Guacamole
> Issue Type: Bug
> Components: guacamole, guacamole-server
> Affects Versions: 1.3.0
> Reporter: Ryan Cai
> Priority: Major
>
> In the below codes, the lock
> +pthread_mutex_lock(&(ssh_client->term_channel_lock))+ , the resource, can
> not be correctly released if
> +libssh2_keepalive_send(ssh_client->session->session, &timeout) >+ +0+.
>
> Locations:
> https://github.com/apache/guacamole-server/blob/b2ae2fdf003a6854ac42877ce0fce8e88ceb038a/src/protocols/ssh/ssh.c#L424-L453
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
