[
https://issues.apache.org/jira/browse/GUACAMOLE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561651#comment-17561651
]
Nick Couchman commented on GUACAMOLE-1630:
------------------------------------------
[[email protected]]: I certainly would agree that there are areas where the
Guacamole code could be improved, but I don't think you've provided nearly
enough information on what you intend to do for this to be at all meaningful.
You talk about "refactoring" in terms of breaking up functions and
deduplicating code, but without more specifics I'm not sure how I could
evaluate the reasonableness of your estimates?
Also, it's unclear to me what the goal of this Jira issue is. If you intend to
participate in the project and submit pull requests, this Jira issue is an
appropriate place for the discussion and will hopefully lead to contributions
in the form of pull requests which can then be reviewed and merged. If you're
simply putting together a research project and trying to gather data for your
research, then Jira is not the correct place, as it isn't intended to be a
general discussion platform, and you should subscribe to one of the mailing
lists (probably dev@) and post your questions, there.
> Potential Refactoring Estimate
> ------------------------------
>
> Key: GUACAMOLE-1630
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-1630
> Project: Guacamole
> Issue Type: Improvement
> Reporter: Alvin Tan Jian Jia
> Priority: Minor
> Attachments: Guacamole-client_1.4.0.csv
>
>
> **Summary**
> I have identified a few classes with refactoring potential along with its
> estimated time to refactor, specifically
> ActiveConnectionPermissionService.java. The estimated time is based on
> historical commits containing refactoring and the complexity of the involved
> classes. The class was refactored once on Sep 20, 2018 along with other
> classes in commit 69f58c8ca314c44822e0eaab354b5f722a01ac89. Given the
> duration of the last refactoring, could it be possible to improve this class
> further? I am probably not qualified and experienced enough to point out the
> exact code needs to be refactored, given my limited knowledge of the project
> and codebase.
>
> **Urgency**
> Low priority. For maintenance of code in the long run.
>
> Hi,
> I am currently doing some research on Estimating Time Taken for Software
> Refactoring. Guacamole is one of my case studies being a highly popular
> project. Would appreciate your kind feedback on the appropriateness of the
> estimated time to refactor.
> I am specifically looking at potential for refactoring, such as breaking
> functions that are too long into shorter functions, or to remove code
> duplication. Would you agree that there could be some modification to the
> code to make it better in the listed classes? And if so, is the estimated
> time appropriate to carry out the improvement? I will be grateful for any
> help you can provide.
> # ActiveConnectionPermissionService.java - 2 hours
> # EntityMapper.java - 2 hours
> # EntityService.java - 3 hours
> Thank you.
> Regards,
> Alvin
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
