[
https://issues.apache.org/jira/browse/GUACAMOLE-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
siva updated GUACAMOLE-2223:
----------------------------
Description:
When session recording is enabled, if [recording.c >
guac_recording_create|https://github.com/apache/guacamole-server/blob/4577484c9e8fc1fdbc20e55d02da4696b7d301b1/src/libguac/recording.c#L42]
returns NULL for whatever reason, the connection is allowed to go instead of
performing a NULL check on <rdp|ssh>_client->recording. This can lead to empty
recording files in some cases.
1) Is this by design?
2) Can we enforce guacamole to not silently fail if recording can't be reported
?
For a simple repro, force return NULL in the guac_recording_create method.
was:
When session recording is enabled, if [recording.c >
guac_recording_create|https://github.com/apache/guacamole-server/blob/4577484c9e8fc1fdbc20e55d02da4696b7d301b1/src/libguac/recording.c#L42]
returns NULL for whatever reason, the connection is allowed to go instead of
performing a NULL check on <rdp|ssh>_client->recording. This can lead to empty
recording files in some cases.
Is this by design? Can we enforce guacamole to not silently fail if recording
can't be reported ?
For a simple repro, force return NULL in the guac_recording_create method.
> Guacamole fails silently when it can't record sessions.
> -------------------------------------------------------
>
> Key: GUACAMOLE-2223
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-2223
> Project: Guacamole
> Issue Type: Bug
> Components: guacamole-server
> Affects Versions: 1.6.0
> Reporter: siva
> Priority: Major
>
> When session recording is enabled, if [recording.c >
> guac_recording_create|https://github.com/apache/guacamole-server/blob/4577484c9e8fc1fdbc20e55d02da4696b7d301b1/src/libguac/recording.c#L42]
> returns NULL for whatever reason, the connection is allowed to go instead of
> performing a NULL check on <rdp|ssh>_client->recording. This can lead to
> empty recording files in some cases.
> 1) Is this by design?
> 2) Can we enforce guacamole to not silently fail if recording can't be
> reported ?
>
> For a simple repro, force return NULL in the guac_recording_create method.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
