[
https://issues.apache.org/jira/browse/GUACAMOLE-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18059826#comment-18059826
]
Nick Couchman commented on GUACAMOLE-2223:
------------------------------------------
I suppose I may be splitting hairs, here, but I don't think it _silently_ fails
- at least, the failures will be logged in the log file:
https://github.com/apache/guacamole-server/blob/4577484c9e8fc1fdbc20e55d02da4696b7d301b1/src/libguac/recording.c#L63-L70
Unless there's another situation we ought to check - like either of these calls:
[https://github.com/apache/guacamole-server/blob/4577484c9e8fc1fdbc20e55d02da4696b7d301b1/src/libguac/recording.c#L73-L74]
It is true that the user will not be warned, but that is likely by design -
it's an administrative concern, and not something that the user is likely to
have any control over. That said, i would not be opposed to a configuration
option that causes the connection to fail if the recording fails. I can
certainly see situations where Guacamole may be used for compliance or security
concerns where a user getting access to a connection and the recording failing
could cause some issues.
> Guacamole fails silently when it can't record sessions.
> -------------------------------------------------------
>
> Key: GUACAMOLE-2223
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-2223
> Project: Guacamole
> Issue Type: Bug
> Components: guacamole-server
> Affects Versions: 1.6.0
> Reporter: siva
> Priority: Major
>
> When session recording is enabled, if [recording.c >
> guac_recording_create|https://github.com/apache/guacamole-server/blob/4577484c9e8fc1fdbc20e55d02da4696b7d301b1/src/libguac/recording.c#L42]
> returns NULL for whatever reason, the connection is allowed to go instead of
> performing a NULL check on <rdp|ssh>_client->recording. This can lead to
> empty/corrupted recording files in some cases.
> 1) Is this by design?
> 2) Can we enforce guacamole to not silently fail if recording can't be
> reported ?
>
> For a simple repro, force return NULL in the guac_recording_create method.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
