[
https://issues.apache.org/jira/browse/GUACAMOLE-2287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18087687#comment-18087687
]
David Bateman commented on GUACAMOLE-2287:
------------------------------------------
Ok, I think I understand, whats going on.. KSM is delegating the decorating of
the userContext entirely to the vault-base, but as I've added additional
attributes the existing wrapped userContext is not sufficient. So this is not a
bug
> The KSM module does not decorate the UserContext and so the User and
> ConnectionGroup Attributes of KSM can not be updated
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: GUACAMOLE-2287
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-2287
> Project: Guacamole
> Issue Type: Bug
> Components: guacamole-vault-ksm
> Affects Versions: 1.6.0
> Reporter: David Bateman
> Priority: Minor
>
> While looking at adding a Hashicorp Vault extension, I of course enormously
> used the existing KSM code as inspiration. However, I noticed a bug when a
> ConnectionGroup (or User) is updated, the REST API returns an error.
>
> This is beacuse the UserContext needs to be wrapped to provide/hide the KSM
> specific attributes like in the TOTP and Restricted extensions, and the
> provider needs to override the "decorate" method. This doesn't stop the KSM
> extension from working, just makes it difficult to modifiy existing
> configurations. I imagine this was missed as KSM only has one attribute and
> its pretty rare to modify it.
> To reproduce this, add a KSM vault to a ConnectionGroup, save it then attempt
> to modify the KSM attribute of the existing ConnectionGroup
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
