Github user denalex commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1353#discussion_r213477883
--- Diff:
pxf/pxf-jdbc/src/main/java/org/apache/hawq/pxf/plugins/jdbc/writercallable/BatchWriterCallable.java
---
@@ -0,0 +1,113 @@
+package org.apache.hawq.pxf.plugins.jdbc.writercallable;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.hawq.pxf.api.OneRow;
+import org.apache.hawq.pxf.plugins.jdbc.JdbcResolver;
+import org.apache.hawq.pxf.plugins.jdbc.JdbcPlugin;
+
+import java.util.LinkedList;
+import java.util.List;
+import java.io.IOException;
+import java.sql.PreparedStatement;
+import java.sql.SQLException;
+
+/**
+ * This writer makes batch INSERTs.
+ *
+ * A call() is required after a certain number of supply() calls
+ */
+class BatchWriterCallable implements WriterCallable {
+ @Override
+ public void supply(OneRow row) throws IllegalStateException {
+ if ((maxRowsCount > 0) && (rows.size() >= maxRowsCount)) {
+ throw new IllegalStateException("Trying to supply() a OneRow
object to a full WriterCallable");
+ }
+ if (row == null) {
+ throw new IllegalArgumentException("Trying to supply() a null
OneRow object");
+ }
+ rows.add(row);
+ }
+
+ @Override
+ public boolean isCallRequired() {
+ if ((maxRowsCount > 0) && (rows.size() >= maxRowsCount)) {
+ return true;
+ }
+ return false;
--- End diff --
would be better to call the method isBatchFull() and provide a 1-liner
implementation:
```
return (maxRowsCount > 0) && (rows.size() >= maxRowsCount)
```
---
