Github user interma commented on the issue:

    https://github.com/apache/hawq/pull/1397
  
    @kuien I do a perf test on your pr, two issues:
    1. query result error
    2. performance downgrade
    
    Details see below, please check code, thanks.
    
    TPCH1G data on my mac, master code
    ```
    tpch=# select count (*) from part, lineitem where p_partkey = l_partkey and 
p_brand = 'Brand#23' and p_container = 'MED BOX';
    count
    -------
      6088
    (1 row)
    
    Time: 3150.873 ms
    tpch=# set hawq_hashjoin_bloomfilter to on;
    SET
    Time: 2.903 ms
    tpch=# select count (*) from part, lineitem where p_partkey = l_partkey and 
p_brand = 'Brand#23' and p_container = 'MED BOX';
    count
    -------
      6088
    (1 row)
    
    Time: 1512.782 ms
    ```
     your code
    ```
    tpch=# select count (*) from part, lineitem where p_partkey = l_partkey and 
p_brand = 'Brand#23' and p_container = 'MED BOX';
     count
    -------
      6088
    (1 row)
    
    Time: 49466.999 ms #<-- result ok, but bad performance
    tpch=# set hawq_hashjoin_bloomfilter to on;                                 
                                            SET
    Time: 13.106 ms
    tpch=# select count (*) from part, lineitem where p_partkey = l_partkey and 
p_brand = 'Brand#23' and p_container = 'MED BOX';
     count
    -------
         0 #<-- result error
    (1 row)
    
    Time: 1888.176 ms 
    ```


---

Reply via email to