[
https://issues.apache.org/jira/browse/HAWQ-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14973765#comment-14973765
]
ASF GitHub Bot commented on HAWQ-47:
------------------------------------
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/34#discussion_r42961439
--- Diff: src/backend/resourcemanager/communication/rmcomm_QD2RM.c ---
@@ -374,20 +374,24 @@ int cleanupQD2RMComm(void)
{
if ( QD2RM_ResourceSets[i]->QD_ResourceList != NULL )
{
- elog( LOG, "Un-returned resource is probed, will be
returned. "
- "(%d MB, %lf CORE) x %d. Conn ID=%d",
- QD2RM_ResourceSets[i]->QD_SegMemoryMB,
- QD2RM_ResourceSets[i]->QD_SegCore,
- QD2RM_ResourceSets[i]->QD_SegCount,
- QD2RM_ResourceSets[i]->QD_Conn_ID);
+ elog(LOG, "Un-returned resource is probed, will be
returned. "
+ "(%d MB, %lf CORE) x %d. Conn ID=%d",
+ QD2RM_ResourceSets[i]->QD_SegMemoryMB,
+ QD2RM_ResourceSets[i]->QD_SegCore,
+ QD2RM_ResourceSets[i]->QD_SegCount,
+ QD2RM_ResourceSets[i]->QD_Conn_ID);
res = returnResource(i, errorbuf, sizeof(errorbuf));
- if ( res != FUNC_RETURN_OK ) {
- elog(LOG, "Fail to return resource when cleaning up
resource context.");
+ if ( res != FUNC_RETURN_OK )
+ {
+ elog(WARNING, "Failed to return resource when cleaning
up "
+ "resource context.");
--- End diff --
code indent, "}" at the next line should match "{"
> Make user able to set statement level resource usage.
> -----------------------------------------------------
>
> Key: HAWQ-47
> URL: https://issues.apache.org/jira/browse/HAWQ-47
> Project: Apache HAWQ
> Issue Type: New Feature
> Components: Resource Manager
> Reporter: Yi Jin
> Assignee: Yi Jin
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> SET STATEMENT_VSEG_MEM=memory_units
> SET STATEMENT_NVSEG=<integer>
> memory_units ::= 128mb|256mb|512mb|1024mb|1gb|2gb|4gb|8gb|16gb
> Resource manager will try to reserve expected resource for current statement
> execution. The default value of STATEMENT_NVSEG is 0, which means the
> statement level setting is not activated, when STATEMENT_NVSEG is greater
> than zero, STATEMENT_MEM overrides the resource queue virtual segment
> resource quota. Memory core ratio derived by resource queue hierarchy and
> cluster capacity.
> If the expected resource specified by STATEMENT_MEM and STATEMENT_NVSEG can
> not be satisfied due to various reason, the session is timed out.
> Yi Jin <y...@pivotal.io>
> Oct 8 (5 days ago)
> to Lei, Jiali, Amy
> 1) If the expected resource specified by STATEMENT_MEM and STATEMENT_NVSEG
> can not be satisfied due to queue capacity limits, the error is reported at
> once, the session is aborted;
> 2) The setting of statement level resource may cause different query plan
> generated; (Change code for passing this into optimizer??)
> 3) If the expected resource can not be satisfied by the other various
> reasons, the session is timed out.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
