[
https://issues.apache.org/jira/browse/HAWQ-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047913#comment-15047913
]
ASF GitHub Bot commented on HAWQ-224:
-------------------------------------
Github user radarwave commented on the pull request:
https://github.com/apache/incubator-hawq/pull/168#issuecomment-163089682
This fix the syntax error but did not fix 'make distprep' option, we might
enable distprep option in the future. So this fix is okay.
The only issue is the commit message, we should follow the format. Please
update the commit message before we merge it in. Thanks.
For example:
"HAWQ-224. Fix syntax error of make distprep."
> make distprep: /contrib/Makefile: error: commands commence before first target
> ------------------------------------------------------------------------------
>
> Key: HAWQ-224
> URL: https://issues.apache.org/jira/browse/HAWQ-224
> Project: Apache HAWQ
> Issue Type: Bug
> Components: Build
> Reporter: SuperJDC
> Assignee: Radar Lei
>
> steps:
> step1: ./configure --prefix=/home/hawq/hawqinstall/
> ok
> step2: make
> All of hawq successfully made. Ready to install.
> step3: make distprep
> MakeFile:12: *** commands commence before first target. Stop.
> I foud tab in /contrib/Makefile. Line 8, 9, 10, 11, 12, 13, 21, 22, 23, 27,
> 28, 29, 30, all start with tab.
> Additionally, line 8, there is no subdirectory: pgbench. And line 11, has no
> end, which should be ended with \.
> Thanks!
> There will be no error, when I do the follow (2) steps:
> First, add ' \' to the end of line 11.
> Secondly, replace 'pgbench' with 'pgcrypto', in line 8. (Because contrib has
> no subdirectory: pgbench, but pgcrypto.)
> Thanks!
> Thanks for Radar Lei's effort work!
> I'm looking forward 'distprep' and 'dist' will be supported soon.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
