[
https://issues.apache.org/jira/browse/HAWQ-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15056957#comment-15056957
]
ASF GitHub Bot commented on HAWQ-191:
-------------------------------------
Github user shivzone commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/174#discussion_r47574985
--- Diff:
pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/rest/InvalidPathResource.java
---
@@ -153,9 +167,39 @@ private String parseVersion(String path) {
}
/**
+ * Parses the version part from the path.
--- End diff --
These are private methods used only by wrongPath(). Having an enum and
separate function seems to be an overkill for this. will do away with helper
functions and use pathSegments directly to extract the version and endpoint.
> Remove Analyzer from PXF
> ------------------------
>
> Key: HAWQ-191
> URL: https://issues.apache.org/jira/browse/HAWQ-191
> Project: Apache HAWQ
> Issue Type: Improvement
> Components: PXF
> Reporter: Noa Horn
> Assignee: Shivram Mani
>
> Analyzer plugin was used to gather statistics when running ANALYZE.
> The API provides one function getEstimatedStats() which returns the estimated
> number of tuples, blocks and the size of block.
> We also have one implementation for it - HdfsAnalyzer.
> After the introduction of advanced stats (HAWQ-44), the Analyzer is no longer
> used by HAWQ. Instead a new function in the Fragmenter API
> (getFragmentsStats) is used to gather initial statistics for the data source,
> and further queries gather sampling tuples for that data source.
> The advantage in the new approach is that the Fragmenter.getFragmentsStats
> uses only the Fragmenter to gather stats. The Analyzer, on the other hand,
> instantiated both Fragmenter and Accessor of the table in order to estimate
> the number of tuples. In the HdfsAnalyzer implementation, it caused a
> dependency of pxf-hdfs jar on pxf-service (which takes care of instantiating
> the plugins), which is contrary to the isolation we want to achieve between
> core functionality (pxf-service) and the plugins (pxf-hdfs, pxf-hive,
> pxf-hbase, etc.)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
