[
https://issues.apache.org/jira/browse/HAWQ-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15061693#comment-15061693
]
ASF GitHub Bot commented on HAWQ-255:
-------------------------------------
Github user wangzw commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/191#discussion_r47878881
--- Diff: src/backend/storage/smgr/smgr.c ---
@@ -1327,28 +1327,6 @@ smgrDoDeleteActions(
palloc0((*listCount) *
sizeof(PersistentFileSysObjStateChangeResult));
/*
- * There are two situations where we get here.
CommitTransaction()/AbortTransaction() or via
- * AbortSubTransaction(). In the first case, we have already obtained
the MirroredLock and
- * CheckPointStartLock. In the second case, we have not obtained the
locks, so we attempt
- * to get them to make sure proper lock order is maintained.
- *
- * Normally, if a relation lock is needed, it is obtained before the
MirroredLock and CheckPointStartLock,
- * but we have not yet obtained an EXCLUSIVE
LockRelationForResynchronize. This lock will be obtained in
- * PersistentFileSysObj_EndXactDrop(). This is an exception to the
normal lock ordering, which is done
- * to reduce the time that the lock is held, thus allowing a larger
window of time for filerep
- * resynchronization to obtain the lock.
- */
-
- /*
- * The logic will eventually obtain a CheckpointStartLock in
PersistentRelation_Dropped(),
- * but functions called from this function my obtain Exclusive locks
before the
- * CheckpointStartLock is obtained. This could cause a potential
deadlock in the future.
- * We need to take a CheckpointStartLock here to maintain proper lock
ordering
- * (i.e. MirrorLock -> CheckpointStartLock ).
- */
- CHECKPOINT_START_LOCK;
-
--- End diff --
Nice work #178
> Checkpoint is blocked by TRANSACTION ABORT for INSERTING INTO a big partition
> table
> -----------------------------------------------------------------------------------
>
> Key: HAWQ-255
> URL: https://issues.apache.org/jira/browse/HAWQ-255
> Project: Apache HAWQ
> Issue Type: Bug
> Reporter: Ming LI
> Assignee: Lei Chang
>
> If at the same time there are other INSERT commands running in parallel, it
> will generates a lot of pg_xlog files. If at this time the system/master
> nodes crashed, it will take a very long time for recovery.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
