[ 
https://issues.apache.org/jira/browse/HAWQ-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15128343#comment-15128343
 ] 

ASF GitHub Bot commented on HAWQ-178:
-------------------------------------

Github user tzolov commented on the pull request:

    https://github.com/apache/incubator-hawq/pull/302#issuecomment-178608613
  
    @hornn, @adamjshook  
    As an experimenti've rempimplemented/replaced the 
`JsonRecordReader`&`JsonStreamReader` with ideas and code boroed from the 
[json-mapreduce](https://github.com/alexholmes/json-mapreduce) project.  I 
really like the result. It comes with a (sort of) JsonLexer/Parser that solves 
some of the shortcomings in the current implementation. For example having the 
`identifier` in the nested object(s) values will be handled. 
    Furthermore they why how the identifier  is used is slightly differently 
and more powerful. The identifier refers to a member name which it will use to 
determine the encapsulating object to return.  This is  superior functionality 
over  what we have at the moment as you can point to multiline json objects 
that don't have a parent identifier. 
    
    Shall i add this change to this PR or to a separate one after this has been 
merged? 
    Personally i think it is better to add it now as it changes the 
`identifier` semantics and would be inconvenient for the potential users to 
learn/unlearn. Alternatively we can drop the current JsonRecordReader form this 
PR and introduce the new code as an extension i another one. What do you think?



> Add JSON plugin support in code base
> ------------------------------------
>
>                 Key: HAWQ-178
>                 URL: https://issues.apache.org/jira/browse/HAWQ-178
>             Project: Apache HAWQ
>          Issue Type: New Feature
>          Components: PXF
>            Reporter: Goden Yao
>            Assignee: Goden Yao
>             Fix For: backlog
>
>         Attachments: PXFJSONPluginforHAWQ2.0andPXF3.0.0.pdf, 
> PXFJSONPluginforHAWQ2.0andPXF3.0.0v.2.pdf
>
>
> JSON has been a popular format used in HDFS as well as in the community, 
> there has been a few JSON PXF plugins developed by the community and we'd 
> like to see it being incorporated into the code base as an optional package.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to