[
https://issues.apache.org/jira/browse/HAWQ-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15129402#comment-15129402
]
ASF GitHub Bot commented on HAWQ-369:
-------------------------------------
Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/324#discussion_r51658617
--- Diff: src/backend/commands/dbcommands.c ---
@@ -848,11 +848,18 @@ createdb(CreatedbStmt *stmt)
* Check for db name conflict. This is just to give a more friendly
error
* message than "unique index violation". There's a race condition but
* we're willing to accept the less friendly message in that case.
+ * Also check that user is not trying to use "hcatalog" as a database
name,
+ * because it's already reserved for hcatalog feature integration.
*/
if (OidIsValid(get_database_oid(dbname)))
- ereport(ERROR,
- (errcode(ERRCODE_DUPLICATE_DATABASE),
- errmsg("database \"%s\" already exists",
dbname)));
+ if (strcmp(dbname, HcatalogDbName) == 0)
+ ereport(ERROR,
+ (errcode(ERRCODE_RESERVED_NAME),
+ errmsg("\"%s\" is a reserved
name for hcatalog feature integration", HcatalogDbName)));
--- End diff --
same comment about the message :)
> Hcatalog as reserved name
> -------------------------
>
> Key: HAWQ-369
> URL: https://issues.apache.org/jira/browse/HAWQ-369
> Project: Apache HAWQ
> Issue Type: New Feature
> Components: PXF
> Reporter: Goden Yao
> Assignee: Goden Yao
> Labels: Hcatalog
>
> https://github.com/apache/incubator-hawq/tree/master/src/test/regress
> With Hcatalog integration, we've reserved "hcatalog" as keyword for the
> following scenarios
> *Acceptance Criteria*
> 1. {code}CREATE DATABASE hcatalog{code} should fail with a reserved name error
> {code}
> "hcatalog" is a reserved name for hcatalog feature integration
> {code}
> 2. {code}CREATE SCHEMA hcatalog{code} should be fine.
> 3. {code}CREATE TABLE hcatalog(hcatalog int){code} should be fine, there is
> no ambiguity for table/column names.
> 4. {code}ALTER DATABASE name RENAME to hcatalog{code} should fail with a
> reserved name error
> {code}"hcatalog" is a reserved name for hcatalog feature integration{code}
> 5. {code}ALTER DATABASE hcatalog RENAME to xxx{code} should fail with a
> system error
> {code}permission denied to ALTER DATABASE hcatalog is reserved for system
> use{code}
> 6. {code}\connect hcatalog{code} should fail with a system error
> {code}hcatalog database is only for system use{code}
> 7. Add regression tests to the above scenarios
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
