[ 
https://issues.apache.org/jira/browse/HAWQ-539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195014#comment-15195014
 ] 

ASF GitHub Bot commented on HAWQ-539:
-------------------------------------

GitHub user wcl14 opened a pull request:

    https://github.com/apache/incubator-hawq/pull/453

    HAWQ-539. Add fault injection for dispatcher QD side

    Add three fault injections: connection_fail_after_gang_creation, 
create_cdb_dispath_result_object , dispmgt_concurrent_connect for dispatcher QD 
side.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wcl14/incubator-hawq HAWQ-539

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hawq/pull/453.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #453
    
----
commit 2fd287297292bec2db64518614cf33efdb01218f
Author: Chunling Wang <[email protected]>
Date:   2016-03-15T02:15:03Z

    HAWQ-539. Add fault injection for dispatcher QD site

----


> Improve code coverage for dispatcher: connection_fail_after_gang_creation& 
> create_cdb_dispath_result_object& dispmgt_concurrent_connect
> ---------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HAWQ-539
>                 URL: https://issues.apache.org/jira/browse/HAWQ-539
>             Project: Apache HAWQ
>          Issue Type: Sub-task
>          Components: Dispatcher
>            Reporter: Chunling Wang
>            Assignee: Lei Chang
>
> add three fault injections below:
> 1. connection_fail_after_gang_creation
> In function dispatcher_bind_executor() of dispatcher.c, we inject faults 
> before connection rebind.
> #ifdef FAULT_INJECTOR
>                               FaultInjector_InjectFaultIfSet(
>                                                                               
>            ConnectionFailAfterGangCreation,
>                                                                               
>            DDLNotSpecified,
>                                                                               
>            "",  // databaseName
>                                                                               
>            ""); // tableName
> #endif
> 2. create_cdb_dispath_result_object
> In function cdbdisp_makeResult() of cdbdispatchresult.c, we inject 
> out-of-memory before calling PQExpBufferBroken().
> #ifdef FAULT_INJECTOR
>                               FaultInjector_InjectFaultIfSet(
>                                                                               
>            CreateCdbDispathResultObject,
>                                                                               
>            DDLNotSpecified,
>                                                                               
>            "",  // databaseName
>                                                                               
>            ""); // tableName
> #endif
> 3. worker_manager_submit_job
> Inject error in function workermgr_submit_job() of workermgr.c.
> #ifdef FAULT_INJECTOR
>                               FaultInjector_InjectFaultIfSet(
>                                                                               
>            WorkerManagerSubmitJob,
>                                                                               
>            DDLNotSpecified,
>                                                                               
>            "",  // databaseName
>                                                                               
>            ""); // tableName
> #endif



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to